milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity
rust-bitcoin-unsafe-fast/hashes/extended_tests/schemars/README.md

12 lines
306 B
Markdown
Raw Normal View History

Fix pinning (schemars and MSRV) Done as is single patch to make sure all the docs and CI are in sync and correct. We currently pin the `schemars` dependency using `<=0.8.3` as well as a the `dyn-clone` transient dependency in the manifest (`hashes` and the extended test crate). This is incorrect because it makes usage of the crate klunky (or possibly impossible) if downstream users wish to use a later version of `schemars`. Observe also that we do not have to pin `schemars`, we do however have to pin the `serde` crate if either `serde` or `schemars` features are enabled. Do so in CI and document in the readme file within hashes. Currently we have a pin remaining from the old MSRV (`syn` due to use of `matches!`). Fix pinning by: - Remove pin in manifest for `schemars` - Fix pinning for MSRV in CI and docs (this includes documenting pinning requirements for `schemars` feature because it is related to the other pin of `serde`) in both `hashes` readme and main repo readme.
2023-03-06 22:39:20 +00:00
# Test crate for the schemars feature
Run as usual with `cargo test`.
## Minimum Supported Rust Version (MSRV)
extended_tests: Remove stale docs We no longer need to pin `syn`; remove stale docs.
2023-04-19 23:17:10 +00:00
To run the tests with the MSRV you will need to pin `serde`:
Fix pinning (schemars and MSRV) Done as is single patch to make sure all the docs and CI are in sync and correct. We currently pin the `schemars` dependency using `<=0.8.3` as well as a the `dyn-clone` transient dependency in the manifest (`hashes` and the extended test crate). This is incorrect because it makes usage of the crate klunky (or possibly impossible) if downstream users wish to use a later version of `schemars`. Observe also that we do not have to pin `schemars`, we do however have to pin the `serde` crate if either `serde` or `schemars` features are enabled. Do so in CI and document in the readme file within hashes. Currently we have a pin remaining from the old MSRV (`syn` due to use of `matches!`). Fix pinning by: - Remove pin in manifest for `schemars` - Fix pinning for MSRV in CI and docs (this includes documenting pinning requirements for `schemars` feature because it is related to the other pin of `serde`) in both `hashes` readme and main repo readme.
2023-03-06 22:39:20 +00:00
- `cargo update -p serde --precise 1.0.156`
schemars: Add pinning docs Not totally necessary but since I went to the trouble of working out the last working version add it to the docs so the next guy can grep for `cargo update` to find them.
2023-06-28 05:30:22 +00:00
- `cargo update -p regex --precise 1.7.3`
- `cargo update -p chrono --precise 0.4.24`