milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Deprecate `Script::is_provably_unspendable` 

This method is not really that useful because it checked an arbitrary
condition. There already exists `OP_RETURN` semantics and the method
didn't cover all possible ways the script may be invalid.

This deprecates the method and documents why.
This commit is contained in:
Martin Habovstiak 2023-12-15 23:13:46 +01:00
parent a90104af2d
commit 089ce8f0fb
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bitcoin/src/blockdata/script/borrowed.rs
View File

@ -353,7 +353,11 @@ impl Script {
} }
} }
/// Checks whether a script can be proven to have no satisfying input. /// Checks whether a script is trivially known to have no satisfying input.
///
/// This method has potentially confusing semantics and an unclear purpose, so it's going to be
/// removed. Use `is_op_return` if you want `OP_RETURN` semantics.
#[deprecated(since = "TBD", note = "The method is not very useful, you might want `is_op_return`")]
#[inline] #[inline]
pub fn is_provably_unspendable(&self) -> bool { pub fn is_provably_unspendable(&self) -> bool {
use crate::blockdata::opcodes::Class::{IllegalOp, ReturnOp}; use crate::blockdata::opcodes::Class::{IllegalOp, ReturnOp};