milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

comment only: explain reason for swap bytes

This commit is contained in:
Riccardo Casatta 2021-07-02 12:03:46 +02:00
parent 95460f5e3c
commit 11d5a30f86
No known key found for this signature in database
GPG Key ID: FD986A969E450397
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/network/address.rs
View File

@ -69,6 +69,8 @@ impl Address {
} }
fn addr_to_be(addr: [u16; 8]) -> [u16; 8] { fn addr_to_be(addr: [u16; 8]) -> [u16; 8] {
// consensus_encode always encodes in LE, and we want to encode in BE.
// this utility fn swap bytes before encoding so that the encoded result will be BE
let mut result = addr.clone(); let mut result = addr.clone();
for i in 0..8 { for i in 0..8 {
result[i] = result[i].swap_bytes(); result[i] = result[i].swap_bytes();
@ -84,6 +86,9 @@ impl Encodable for Address {
) -> Result<usize, io::Error> { ) -> Result<usize, io::Error> {
let len = self.services.consensus_encode(&mut s)? let len = self.services.consensus_encode(&mut s)?
+ addr_to_be(self.address).consensus_encode(&mut s)? + addr_to_be(self.address).consensus_encode(&mut s)?
// consensus_encode always encodes in LE, and we want to encode in BE.
//TODO `len += io::Write::write(&mut e, &self.port.to_be_bytes())?;` when MSRV >= 1.32
+ self.port.swap_bytes().consensus_encode(s)?; + self.port.swap_bytes().consensus_encode(s)?;
Ok(len) Ok(len)
} }
@ -270,6 +275,9 @@ impl Encodable for AddrV2Message {
len += self.time.consensus_encode(&mut e)?; len += self.time.consensus_encode(&mut e)?;
len += VarInt(self.services.as_u64()).consensus_encode(&mut e)?; len += VarInt(self.services.as_u64()).consensus_encode(&mut e)?;
len += self.addr.consensus_encode(&mut e)?; len += self.addr.consensus_encode(&mut e)?;
// consensus_encode always encodes in LE, and we want to encode in BE.
//TODO `len += io::Write::write(&mut e, &self.port.to_be_bytes())?;` when MSRV >= 1.32
len += self.port.swap_bytes().consensus_encode(e)?; len += self.port.swap_bytes().consensus_encode(e)?;
Ok(len) Ok(len)
} }