milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#3819: hashes: Hide both macros 

87293dfdd3 api: Run just check-api (Tobin C. Harding)
ed387e5f1d hashes: Hide both macros (Tobin C. Harding)

Pull request description:

  We have two macro definitions feature gated on `serde`. At some stage we added the `doc(hidden)` attribute to one of them but forgot to add it to the other. This technically makes our features non-additive. This macro is "internal" so its unlikely that this is being used in the wild.

  Add `doc(hidden)` to the `serde_impl` macro that is missing it.

  Found by `cargo semver-checks` after recent upgrade to 0.38

ACKs for top commit:
  storopoli:
    ACK 87293dfdd3
  apoelstra:
    ACK 87293dfdd38be71938ae9d6a9981eb4569de3521; successfully ran local tests

Tree-SHA512: 3773eb42684bce56928f2d3f87993d010dd36634fda8dfa6b18b27a36b6c4bb521d711340a4868270dbd2d0c6a11715f9a1998ff3deb6900bd4227a44722a11e
This commit is contained in:
merge-script 2024-12-29 21:25:54 +00:00
parent b2a2e8e708 87293dfdd3
commit 148b8b19dd
No known key found for this signature in database
GPG Key ID: C588D63CE41B97C1
3 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
api/hashes/alloc-only.txt
View File

@ -859,7 +859,6 @@ pub fn bitcoin_hashes::siphash24::State::fmt(&self, f: &mut core::fmt::Formatter
pub macro bitcoin_hashes::hash_newtype!
pub macro bitcoin_hashes::impl_debug_only_for_newtype!
pub macro bitcoin_hashes::impl_hex_for_newtype!
pub macro bitcoin_hashes::serde_impl!
pub macro bitcoin_hashes::sha256t_hash_newtype!
pub macro bitcoin_hashes::sha256t_tag!
pub mod bitcoin_hashes

1
api/hashes/no-features.txt
View File

@ -806,7 +806,6 @@ pub fn bitcoin_hashes::siphash24::State::clone(&self) -> bitcoin_hashes::siphash
pub fn bitcoin_hashes::siphash24::State::fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result
pub macro bitcoin_hashes::hash_newtype!
pub macro bitcoin_hashes::impl_debug_only_for_newtype!
pub macro bitcoin_hashes::serde_impl!
pub macro bitcoin_hashes::sha256t_hash_newtype!
pub macro bitcoin_hashes::sha256t_tag!
pub mod bitcoin_hashes

1
hashes/src/macros.rs
View File

@ -533,6 +533,7 @@ macro_rules! serde_impl(
));
/// Does an "empty" serde implementation for the configuration without serde feature.
#[doc(hidden)]
#[macro_export]
#[cfg(not(feature = "serde"))]
macro_rules! serde_impl(