From c63f80baec0780622d70e4c8699369b0a972cb62 Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Wed, 21 May 2025 10:32:17 +1000 Subject: [PATCH] Remove impl From for FeeRate This function leaks the inner unit of `FeeRate`. We want to change the unit, best to break downstream so they notice. --- units/src/fee_rate/mod.rs | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/units/src/fee_rate/mod.rs b/units/src/fee_rate/mod.rs index 520790e37..6f7fe7fab 100644 --- a/units/src/fee_rate/mod.rs +++ b/units/src/fee_rate/mod.rs @@ -131,10 +131,6 @@ impl FeeRate { } } -impl From for u64 { - fn from(value: FeeRate) -> Self { value.to_sat_per_kwu() } -} - crate::internal_macros::impl_op_for_references! { impl ops::Add for FeeRate { type Output = FeeRate; @@ -195,12 +191,6 @@ mod tests { use super::*; - #[test] - fn sanity_check() { - let fee_rate: u64 = u64::from(FeeRate::from_sat_per_kwu(100)); - assert_eq!(fee_rate, 100_u64); - } - #[test] #[allow(clippy::op_ref)] fn feerate_div_nonzero() {