diff --git a/bitcoin/examples/handshake.rs b/bitcoin/examples/handshake.rs index b3f98d18..12da7e59 100644 --- a/bitcoin/examples/handshake.rs +++ b/bitcoin/examples/handshake.rs @@ -6,7 +6,7 @@ use std::time::{SystemTime, UNIX_EPOCH}; use std::{env, process}; use bitcoin::consensus::{encode, Decodable}; -use bitcoin::network::{address, constants, message, message_network}; +use bitcoin::p2p::{address, constants, message, message_network}; use bitcoin::secp256k1; use bitcoin::secp256k1::rand::Rng; diff --git a/bitcoin/src/address.rs b/bitcoin/src/address.rs index afa42dea..41345867 100644 --- a/bitcoin/src/address.rs +++ b/bitcoin/src/address.rs @@ -46,7 +46,7 @@ use crate::blockdata::script::witness_version::{self, WitnessVersion}; use crate::blockdata::script::{self, Script, ScriptBuf}; use crate::crypto::key::{PublicKey, TapTweak, TweakedPublicKey, UntweakedPublicKey}; use crate::hash_types::{PubkeyHash, ScriptHash}; -use crate::network::constants::Network; +use crate::p2p::constants::Network; use crate::prelude::*; use crate::taproot::TapNodeHash; @@ -996,7 +996,7 @@ mod tests { use super::*; use crate::crypto::key::PublicKey; - use crate::network::constants::Network::{Bitcoin, Testnet}; + use crate::p2p::constants::Network::{Bitcoin, Testnet}; fn roundtrips(addr: &Address) { assert_eq!( diff --git a/bitcoin/src/bip32.rs b/bitcoin/src/bip32.rs index a1513a72..79cdc6b8 100644 --- a/bitcoin/src/bip32.rs +++ b/bitcoin/src/bip32.rs @@ -23,7 +23,7 @@ use crate::crypto::key::{self, KeyPair, PrivateKey, PublicKey}; use crate::hash_types::XpubIdentifier; use crate::internal_macros::impl_bytes_newtype; use crate::io::Write; -use crate::network::constants::Network; +use crate::p2p::constants::Network; use crate::prelude::*; /// A chain code @@ -866,7 +866,7 @@ mod tests { use super::ChildNumber::{Hardened, Normal}; use super::*; use crate::internal_macros::hex; - use crate::network::constants::Network::{self, Bitcoin}; + use crate::p2p::constants::Network::{self, Bitcoin}; #[test] fn test_parse_derivation_path() { diff --git a/bitcoin/src/blockdata/constants.rs b/bitcoin/src/blockdata/constants.rs index 8a368d45..07a424e6 100644 --- a/bitcoin/src/blockdata/constants.rs +++ b/bitcoin/src/blockdata/constants.rs @@ -20,7 +20,7 @@ use crate::blockdata::script; use crate::blockdata::transaction::{OutPoint, Sequence, Transaction, TxIn, TxOut}; use crate::blockdata::witness::Witness; use crate::internal_macros::impl_bytes_newtype; -use crate::network::constants::Network; +use crate::p2p::constants::Network; use crate::pow::CompactTarget; use crate::Amount; @@ -198,7 +198,7 @@ mod test { use crate::blockdata::locktime::absolute; use crate::consensus::encode::serialize; use crate::internal_macros::hex; - use crate::network::constants::Network; + use crate::p2p::constants::Network; #[test] fn bitcoin_genesis_first_transaction() { diff --git a/bitcoin/src/blockdata/transaction.rs b/bitcoin/src/blockdata/transaction.rs index edd0c223..d3327fc7 100644 --- a/bitcoin/src/blockdata/transaction.rs +++ b/bitcoin/src/blockdata/transaction.rs @@ -68,7 +68,7 @@ impl OutPoint { /// /// ```rust /// use bitcoin::constants::genesis_block; - /// use bitcoin::network::constants::Network; + /// use bitcoin::p2p::constants::Network; /// /// let block = genesis_block(Network::Bitcoin); /// let tx = &block.txdata[0]; @@ -1508,7 +1508,7 @@ mod tests { #[test] fn test_is_coinbase() { use crate::blockdata::constants; - use crate::network::constants::Network; + use crate::p2p::constants::Network; let genesis = constants::genesis_block(Network::Bitcoin); assert!(genesis.txdata[0].is_coinbase()); diff --git a/bitcoin/src/consensus/encode.rs b/bitcoin/src/consensus/encode.rs index 7f5ab21e..297d1c08 100644 --- a/bitcoin/src/consensus/encode.rs +++ b/bitcoin/src/consensus/encode.rs @@ -26,7 +26,7 @@ use crate::blockdata::transaction::{Transaction, TxIn, TxOut}; use crate::hash_types::{BlockHash, FilterHash, FilterHeader, TxMerkleNode}; use crate::io::{self, Cursor, Read}; #[cfg(feature = "std")] -use crate::network::{ +use crate::p2p::{ address::{AddrV2Message, Address}, message_blockdata::Inventory, }; @@ -836,7 +836,7 @@ mod tests { use super::*; use crate::consensus::{deserialize_partial, Decodable, Encodable}; #[cfg(feature = "std")] - use crate::network::{message_blockdata::Inventory, Address}; + use crate::p2p::{message_blockdata::Inventory, Address}; #[test] fn serialize_int_test() { diff --git a/bitcoin/src/consensus/params.rs b/bitcoin/src/consensus/params.rs index cd9cb5bc..36861564 100644 --- a/bitcoin/src/consensus/params.rs +++ b/bitcoin/src/consensus/params.rs @@ -6,7 +6,7 @@ //! chains (such as mainnet, testnet). //! -use crate::network::constants::Network; +use crate::p2p::constants::Network; use crate::pow::Work; /// Parameters that influence chain consensus. diff --git a/bitcoin/src/crypto/key.rs b/bitcoin/src/crypto/key.rs index e870592c..5e08c7e5 100644 --- a/bitcoin/src/crypto/key.rs +++ b/bitcoin/src/crypto/key.rs @@ -18,7 +18,7 @@ pub use secp256k1::{self, constants, KeyPair, Parity, Secp256k1, Verification, X use crate::crypto::ecdsa; use crate::hash_types::{PubkeyHash, WPubkeyHash}; -use crate::network::constants::Network; +use crate::p2p::constants::Network; use crate::prelude::*; use crate::taproot::{TapNodeHash, TapTweakHash}; use crate::{base58, io}; @@ -741,7 +741,7 @@ mod tests { use super::*; use crate::address::Address; use crate::io; - use crate::network::constants::Network::{Bitcoin, Testnet}; + use crate::p2p::constants::Network::{Bitcoin, Testnet}; #[test] fn test_key_derivation() { diff --git a/bitcoin/src/crypto/sighash.rs b/bitcoin/src/crypto/sighash.rs index ec4a2ad7..eb537479 100644 --- a/bitcoin/src/crypto/sighash.rs +++ b/bitcoin/src/crypto/sighash.rs @@ -1120,7 +1120,7 @@ mod tests { use crate::crypto::key::PublicKey; use crate::crypto::sighash::{LegacySighash, TapSighash}; use crate::internal_macros::hex; - use crate::network::constants::Network; + use crate::p2p::constants::Network; use crate::taproot::TapLeafHash; extern crate serde_json; diff --git a/bitcoin/src/lib.rs b/bitcoin/src/lib.rs index 99f2ef02..4bcc0783 100644 --- a/bitcoin/src/lib.rs +++ b/bitcoin/src/lib.rs @@ -92,7 +92,7 @@ mod parse; mod serde_utils; #[macro_use] -pub mod network; +pub mod p2p; pub mod address; pub mod amount; pub mod base58; @@ -146,7 +146,7 @@ pub use crate::hash_types::{ BlockHash, PubkeyHash, ScriptHash, Txid, WPubkeyHash, WScriptHash, Wtxid, }; pub use crate::merkle_tree::MerkleBlock; -pub use crate::network::constants::Network; +pub use crate::p2p::constants::Network; pub use crate::pow::{CompactTarget, Target, Work}; pub use crate::psbt::Psbt; diff --git a/bitcoin/src/network/address.rs b/bitcoin/src/p2p/address.rs similarity index 99% rename from bitcoin/src/network/address.rs rename to bitcoin/src/p2p/address.rs index f20907c3..5696026b 100644 --- a/bitcoin/src/network/address.rs +++ b/bitcoin/src/p2p/address.rs @@ -11,7 +11,7 @@ use std::net::{Ipv4Addr, Ipv6Addr, SocketAddr, SocketAddrV4, SocketAddrV6, ToSoc use crate::consensus::encode::{self, Decodable, Encodable, ReadExt, VarInt, WriteExt}; use crate::io; -use crate::network::constants::ServiceFlags; +use crate::p2p::constants::ServiceFlags; use crate::prelude::*; /// A message which can be sent on the Bitcoin network @@ -311,7 +311,7 @@ mod test { use super::{AddrV2, AddrV2Message, Address}; use crate::consensus::encode::{deserialize, serialize}; use crate::internal_macros::hex; - use crate::network::constants::ServiceFlags; + use crate::p2p::constants::ServiceFlags; #[test] fn serialize_address_test() { diff --git a/bitcoin/src/network/constants.rs b/bitcoin/src/p2p/constants.rs similarity index 98% rename from bitcoin/src/network/constants.rs rename to bitcoin/src/p2p/constants.rs index 1b4d172f..7e86ebaa 100644 --- a/bitcoin/src/network/constants.rs +++ b/bitcoin/src/p2p/constants.rs @@ -16,7 +16,7 @@ //! # Example: encoding a network's magic bytes //! //! ```rust -//! use bitcoin::network::constants::Network; +//! use bitcoin::p2p::constants::Network; //! use bitcoin::consensus::encode::serialize; //! //! let network = Network::Bitcoin; @@ -82,7 +82,7 @@ impl Network { /// # Examples /// /// ```rust - /// use bitcoin::network::constants::{Network, Magic}; + /// use bitcoin::p2p::constants::{Network, Magic}; /// use std::convert::TryFrom; /// /// assert_eq!(Ok(Network::Bitcoin), Network::try_from(Magic::from_bytes([0xF9, 0xBE, 0xB4, 0xD9]))); @@ -96,7 +96,7 @@ impl Network { /// # Examples /// /// ```rust - /// use bitcoin::network::constants::{Network, Magic}; + /// use bitcoin::p2p::constants::{Network, Magic}; /// /// let network = Network::Bitcoin; /// assert_eq!(network.magic(), Magic::from_bytes([0xF9, 0xBE, 0xB4, 0xD9])); @@ -148,7 +148,7 @@ impl Network { /// # Examples /// /// ```rust - /// use bitcoin::network::constants::Network; + /// use bitcoin::p2p::constants::Network; /// use bitcoin::blockdata::constants::ChainHash; /// /// let network = Network::Bitcoin; @@ -161,7 +161,7 @@ impl Network { /// # Examples /// /// ```rust - /// use bitcoin::network::constants::Network; + /// use bitcoin::p2p::constants::Network; /// use bitcoin::blockdata::constants::ChainHash; /// use std::convert::TryFrom; /// @@ -723,7 +723,7 @@ mod tests { #[derive(Serialize, Deserialize, PartialEq, Debug)] #[serde(crate = "actual_serde")] struct T { - #[serde(with = "crate::network::constants::as_core_arg")] + #[serde(with = "crate::p2p::constants::as_core_arg")] pub network: Network, } diff --git a/bitcoin/src/network/message.rs b/bitcoin/src/p2p/message.rs similarity index 98% rename from bitcoin/src/network/message.rs rename to bitcoin/src/p2p/message.rs index 75d22de6..71bec7c4 100644 --- a/bitcoin/src/network/message.rs +++ b/bitcoin/src/p2p/message.rs @@ -16,9 +16,9 @@ use crate::blockdata::{block, transaction}; use crate::consensus::encode::{self, CheckedData, Decodable, Encodable, VarInt}; use crate::io; use crate::merkle_tree::MerkleBlock; -use crate::network::address::{AddrV2Message, Address}; -use crate::network::constants::Magic; -use crate::network::{ +use crate::p2p::address::{AddrV2Message, Address}; +use crate::p2p::constants::Magic; +use crate::p2p::{ message_blockdata, message_bloom, message_compact_blocks, message_filter, message_network, }; use crate::prelude::*; @@ -549,12 +549,12 @@ mod test { use crate::blockdata::transaction::Transaction; use crate::consensus::encode::{deserialize, deserialize_partial, serialize}; use crate::internal_macros::hex; - use crate::network::address::{AddrV2, AddrV2Message, Address}; - use crate::network::constants::{Magic, Network, ServiceFlags}; - use crate::network::message_blockdata::{GetBlocksMessage, GetHeadersMessage, Inventory}; - use crate::network::message_bloom::{BloomFlags, FilterAdd, FilterLoad}; - use crate::network::message_compact_blocks::{GetBlockTxn, SendCmpct}; - use crate::network::message_filter::{ + use crate::p2p::address::{AddrV2, AddrV2Message, Address}; + use crate::p2p::constants::{Magic, Network, ServiceFlags}; + use crate::p2p::message_blockdata::{GetBlocksMessage, GetHeadersMessage, Inventory}; + use crate::p2p::message_bloom::{BloomFlags, FilterAdd, FilterLoad}; + use crate::p2p::message_compact_blocks::{GetBlockTxn, SendCmpct}; + use crate::p2p::message_filter::{ CFCheckpt, CFHeaders, CFilter, GetCFCheckpt, GetCFHeaders, GetCFilters, }; diff --git a/bitcoin/src/network/message_blockdata.rs b/bitcoin/src/p2p/message_blockdata.rs similarity index 99% rename from bitcoin/src/network/message_blockdata.rs rename to bitcoin/src/p2p/message_blockdata.rs index 64273b7b..2a69f1e8 100644 --- a/bitcoin/src/network/message_blockdata.rs +++ b/bitcoin/src/p2p/message_blockdata.rs @@ -12,7 +12,7 @@ use crate::consensus::encode::{self, Decodable, Encodable}; use crate::hash_types::{BlockHash, Txid, Wtxid}; use crate::internal_macros::impl_consensus_encoding; use crate::io; -use crate::network::constants; +use crate::p2p::constants; use crate::prelude::*; /// An inventory item. diff --git a/bitcoin/src/network/message_bloom.rs b/bitcoin/src/p2p/message_bloom.rs similarity index 100% rename from bitcoin/src/network/message_bloom.rs rename to bitcoin/src/p2p/message_bloom.rs diff --git a/bitcoin/src/network/message_compact_blocks.rs b/bitcoin/src/p2p/message_compact_blocks.rs similarity index 100% rename from bitcoin/src/network/message_compact_blocks.rs rename to bitcoin/src/p2p/message_compact_blocks.rs diff --git a/bitcoin/src/network/message_filter.rs b/bitcoin/src/p2p/message_filter.rs similarity index 100% rename from bitcoin/src/network/message_filter.rs rename to bitcoin/src/p2p/message_filter.rs diff --git a/bitcoin/src/network/message_network.rs b/bitcoin/src/p2p/message_network.rs similarity index 97% rename from bitcoin/src/network/message_network.rs rename to bitcoin/src/p2p/message_network.rs index b49974f5..996aad66 100644 --- a/bitcoin/src/network/message_network.rs +++ b/bitcoin/src/p2p/message_network.rs @@ -11,8 +11,8 @@ use hashes::sha256d; use crate::consensus::{encode, Decodable, Encodable, ReadExt}; use crate::internal_macros::impl_consensus_encoding; use crate::io; -use crate::network::address::Address; -use crate::network::constants::{self, ServiceFlags}; +use crate::p2p::address::Address; +use crate::p2p::constants::{self, ServiceFlags}; use crate::prelude::*; /// Some simple messages @@ -146,7 +146,7 @@ mod tests { use super::{Reject, RejectReason, VersionMessage}; use crate::consensus::encode::{deserialize, serialize}; use crate::internal_macros::hex; - use crate::network::constants::ServiceFlags; + use crate::p2p::constants::ServiceFlags; #[test] fn version_message_test() { diff --git a/bitcoin/src/network/mod.rs b/bitcoin/src/p2p/mod.rs similarity index 86% rename from bitcoin/src/network/mod.rs rename to bitcoin/src/p2p/mod.rs index 2e379686..afe4eff9 100644 --- a/bitcoin/src/network/mod.rs +++ b/bitcoin/src/p2p/mod.rs @@ -1,10 +1,9 @@ // SPDX-License-Identifier: CC0-1.0 -//! Bitcoin network support. +//! Bitcoin p2p network types. //! //! This module defines support for (de)serialization and network transport -//! of Bitcoin data and network messages. -//! +//! of Bitcoin data and Bitcoin p2p network messages. pub mod constants; diff --git a/bitcoin/src/psbt/mod.rs b/bitcoin/src/psbt/mod.rs index ee378360..1caa20c6 100644 --- a/bitcoin/src/psbt/mod.rs +++ b/bitcoin/src/psbt/mod.rs @@ -823,7 +823,7 @@ mod tests { use crate::blockdata::transaction::{OutPoint, Sequence, Transaction, TxIn, TxOut}; use crate::blockdata::witness::Witness; use crate::internal_macros::hex; - use crate::network::constants::Network::Bitcoin; + use crate::p2p::constants::Network::Bitcoin; use crate::psbt::map::{Input, Output}; use crate::psbt::raw; use crate::psbt::serialize::{Deserialize, Serialize}; diff --git a/fuzz/fuzz_targets/bitcoin/deser_net_msg.rs b/fuzz/fuzz_targets/bitcoin/deser_net_msg.rs index 883431c1..906bcee9 100644 --- a/fuzz/fuzz_targets/bitcoin/deser_net_msg.rs +++ b/fuzz/fuzz_targets/bitcoin/deser_net_msg.rs @@ -1,7 +1,7 @@ use honggfuzz::fuzz; fn do_test(data: &[u8]) { - let _: Result = + let _: Result = bitcoin::consensus::encode::deserialize(data); } diff --git a/fuzz/fuzz_targets/bitcoin/deserialize_script.rs b/fuzz/fuzz_targets/bitcoin/deserialize_script.rs index 1020e0b0..1cc035d2 100644 --- a/fuzz/fuzz_targets/bitcoin/deserialize_script.rs +++ b/fuzz/fuzz_targets/bitcoin/deserialize_script.rs @@ -1,7 +1,7 @@ use bitcoin::address::Address; use bitcoin::blockdata::script; use bitcoin::consensus::encode; -use bitcoin::network::constants::Network; +use bitcoin::p2p::constants::Network; use honggfuzz::fuzz; fn do_test(data: &[u8]) {