From 1fef5a3dc55bfc1858c32f81f18840ec1d01c807 Mon Sep 17 00:00:00 2001
From: "Tobin C. Harding" <me@tobin.cc>
Date: Thu, 22 May 2025 10:50:34 +1000
Subject: [PATCH] units: re-order ceil/floor functions

We have 4 functions, 2 ceil, 2 floor but they are ordered ceil, floor,
floor, ceil - this causes my head to twitch when I read it.

The logic in the floor versions is easier so put them first, this is
uniform with `fee_rate/mod.rs`.

Code move only.
---
 units/src/fee.rs | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/units/src/fee.rs b/units/src/fee.rs
index e08c9c89a..4dc6c4b56 100644
--- a/units/src/fee.rs
+++ b/units/src/fee.rs
@@ -18,6 +18,24 @@ use NumOpResult as R;
 use crate::{Amount, FeeRate, MathOp, NumOpError as E, NumOpResult, OptionExt, Weight};
 
 impl Amount {
+    /// Checked weight floor division.
+    ///
+    /// Be aware that integer division loses the remainder if no exact division
+    /// can be made. See also [`Self::checked_div_by_weight_ceil`].
+    ///
+    /// Returns [`None`] if overflow occurred.
+    #[must_use]
+    pub const fn checked_div_by_weight_floor(self, weight: Weight) -> Option<FeeRate> {
+        // No `?` operator in const context.
+        match self.to_sat().checked_mul(1_000) {
+            Some(res) => match res.checked_div(weight.to_wu()) {
+                Some(fee_rate) => Some(FeeRate::from_sat_per_kwu(fee_rate)),
+                None => None,
+            },
+            None => None,
+        }
+    }
+
     /// Checked weight ceiling division.
     ///
     /// Be aware that integer division loses the remainder if no exact division
@@ -52,24 +70,6 @@ impl Amount {
         None
     }
 
-    /// Checked weight floor division.
-    ///
-    /// Be aware that integer division loses the remainder if no exact division
-    /// can be made. See also [`Self::checked_div_by_weight_ceil`].
-    ///
-    /// Returns [`None`] if overflow occurred.
-    #[must_use]
-    pub const fn checked_div_by_weight_floor(self, weight: Weight) -> Option<FeeRate> {
-        // No `?` operator in const context.
-        match self.to_sat().checked_mul(1_000) {
-            Some(res) => match res.checked_div(weight.to_wu()) {
-                Some(fee_rate) => Some(FeeRate::from_sat_per_kwu(fee_rate)),
-                None => None,
-            },
-            None => None,
-        }
-    }
-
     /// Checked fee rate floor division.
     ///
     /// Computes the maximum weight that would result in a fee less than or equal to this amount