From 248f9a3b4b4aada463975cc38fc09f742c98799e Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Sun, 6 Nov 2022 06:52:38 +1100 Subject: [PATCH] Use capital letters for Bitcoin Core "Bitcoin Core" is conventionally named using capital letters. Audit and fix all mentions of "Bitcoin Core" in the codebase to use capital letters. --- bitcoin/src/blockdata/script.rs | 2 +- bitcoin/src/sighash.rs | 2 +- bitcoin/src/util/taproot.rs | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/bitcoin/src/blockdata/script.rs b/bitcoin/src/blockdata/script.rs index 11beef98..7f836f53 100644 --- a/bitcoin/src/blockdata/script.rs +++ b/bitcoin/src/blockdata/script.rs @@ -318,7 +318,7 @@ pub fn read_scriptint(v: &[u8]) -> Result { Some(last) => last, None => return Ok(0), }; - // Comment and code copied from bitcoin core: + // Comment and code copied from Bitcoin Core: // https://github.com/bitcoin/bitcoin/blob/447f50e4aed9a8b1d80e1891cda85801aeb80b4e/src/script/script.h#L247-L262 // If the most-significant-byte - excluding the sign bit - is zero // then we're not minimal. Note how this test also rejects the diff --git a/bitcoin/src/sighash.rs b/bitcoin/src/sighash.rs index 9c719683..1a24cd91 100644 --- a/bitcoin/src/sighash.rs +++ b/bitcoin/src/sighash.rs @@ -1152,7 +1152,7 @@ mod tests { #[test] fn test_sighashes_keyspending() { - // following test case has been taken from bitcoin core test framework + // following test case has been taken from Bitcoin Core test framework test_taproot_sighash( "020000000164eb050a5e3da0c2a65e4786f26d753b7bc69691fabccafb11f7acef36641f1846010000003101b2b404392a22000000000017a9147f2bde86fe78bf68a0544a4f290e12f0b7e0a08c87580200000000000017a91425d11723074ecfb96a0a83c3956bfaf362ae0c908758020000000000001600147e20f938993641de67bb0cdd71682aa34c4d29ad5802000000000000160014c64984dc8761acfa99418bd6bedc79b9287d652d72000000", diff --git a/bitcoin/src/util/taproot.rs b/bitcoin/src/util/taproot.rs index 096c71e9..9d61ad72 100644 --- a/bitcoin/src/util/taproot.rs +++ b/bitcoin/src/util/taproot.rs @@ -336,12 +336,12 @@ impl From<&TaprootSpendInfo> for TapTweakHash { /// in a depth-first search (DFS) walk order to construct this tree. /// /// See Wikipedia for more details on [DFS](https://en.wikipedia.org/wiki/Depth-first_search). -// Similar to Taproot Builder in bitcoin core. +// Similar to Taproot Builder in Bitcoin Core. #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)] #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] #[cfg_attr(feature = "serde", serde(crate = "actual_serde"))] pub struct TaprootBuilder { - // The following doc-comment is from bitcoin core, but modified for Rust. It describes the + // The following doc-comment is from Bitcoin Core, but modified for Rust. It describes the // current state of the builder for a given tree. // // For each level in the tree, one NodeInfo object may be present. Branch at index 0 is @@ -1248,7 +1248,7 @@ mod test { #[test] fn control_block_verify() { let secp = Secp256k1::verification_only(); - // test vectors obtained from printing values in feature_taproot.py from bitcoin core + // test vectors obtained from printing values in feature_taproot.py from Bitcoin Core _verify_tap_commitments(&secp, "51205dc8e62b15e0ebdf44751676be35ba32eed2e84608b290d4061bbff136cd7ba9", "6a", "c1a9d6f66cd4b25004f526bfa873e56942f98e8e492bd79ed6532b966104817c2bda584e7d32612381cf88edc1c02e28a296e807c16ad22f591ee113946e48a71e0641e660d1e5392fb79d64838c2b84faf04b7f5f283c9d8bf83e39e177b64372a0cd22eeab7e093873e851e247714eff762d8a30be699ba4456cfe6491b282e193a071350ae099005a5950d74f73ba13077a57bc478007fb0e4d1099ce9cf3d4"); _verify_tap_commitments(&secp, "5120e208c869c40d8827101c5ad3238018de0f3f5183d77a0c53d18ac28ddcbcd8ad", "f4", "c0a0eb12e60a52614986c623cbb6621dcdba3a47e3be6b37e032b7a11c7b98f40090ab1f4890d51115998242ebce636efb9ede1b516d9eb8952dc1068e0335306199aaf103cceb41d9bc37ec231aca89b984b5fd3c65977ce764d51033ac65adb4da14e029b1e154a85bfd9139e7aa2720b6070a4ceba8264ca61d5d3ac27aceb9ef4b54cd43c2d1fd5e11b5c2e93cf29b91ea3dc5b832201f02f7473a28c63246"); _verify_tap_commitments(&secp, "5120567666e7df90e0450bb608e17c01ed3fbcfa5355a5f8273e34e583bfaa70ce09", "203455139bf238a3067bd72ed77e0ab8db590330f55ed58dba7366b53bf4734279ac", "c1a0eb12e60a52614986c623cbb6621dcdba3a47e3be6b37e032b7a11c7b98f400");