milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#1664: Pin syn dependency for MSRV toolchain 

596e756d01 Pin syn dependency for MSRV toolchain (Tobin C. Harding)

Pull request description:

  CI change only, can this merge without 2 acks?

  The recent 1.0.108 `syn` update violated our MSRV, pin `syn` in the CI script.

ACKs for top commit:
  apoelstra:
    ACK 596e756d01

Tree-SHA512: b27d8c18eae36025ac86bbad8f6a8bab3fccc8263e45b7421f216a0b1c6c318e02588c67094d8bd69a23efb32da9dfd10c2a6ce2bd5435133613a38906d83a38
This commit is contained in:
Andrew Poelstra 2023-02-23 22:26:34 +00:00
parent 3a53e7e12e 596e756d01
commit 30633ceb72
No known key found for this signature in database
GPG Key ID: C588D63CE41B97C1
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
README.md
View File

@ -79,6 +79,9 @@ For more information please see `./CONTRIBUTING.md`.
This library should always compile with any combination of features (minus
`no-std`) on **Rust 1.41.1** or **Rust 1.47** with `no-std`.
To build with the MSRV you will need to pin some dependencies, currently this is
only `syn`, and can be achieved using `cargo update -p syn --precise 1.0.107`.
## Installing Rust
Rust can be installed using your package manager of choice or

6
bitcoin/contrib/test.sh
View File

@ -18,6 +18,12 @@ if cargo --version | grep nightly; then
NIGHTLY=true
fi
# Pin dependencies as required if we are using MSRV toolchain.
if cargo --version | grep "1\.41"; then
# 1.0.108 uses `matches!` macro so does not work with Rust 1.41.1, bad `syn` no biscuit.
cargo update -p syn --precise 1.0.107
fi
# We should not have any duplicate dependencies. This catches mistakes made upgrading dependencies
# in one crate and not in another (e.g. upgrade bitcoin_hashes in bitcoin but not in secp).
duplicate_dependencies=$(cargo tree --target=all --all-features --duplicates | wc -l)