milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

hashes: Pin in extra_test 

Note:

- The `extra_test.sh` script runs for all toolchains.
- The `schemars` crate does not use the repo lock files.
- We need to pin some deps when building the `schemars` test.

Pin in the `extra_test.sh` script, and mention it in the docs so the
docs don't go stale next MSRV update.

This was previously unnoticed because of the `run_task` bug.

ref: rust-bitcoin/rust-bitcoin-maintainer-tools#10
This commit is contained in:
Tobin C. Harding 2024-08-10 07:22:37 +10:00
parent 42c7617a46
commit 321d82ca53
No known key found for this signature in database
GPG Key ID: 40BF9E4C269D6607
2 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hashes/contrib/extra_tests.sh
View File

@ -5,5 +5,12 @@ set -euox pipefail
REPO_DIR=$(git rev-parse --show-toplevel) REPO_DIR=$(git rev-parse --show-toplevel)
pushd "$REPO_DIR/hashes/extended_tests/schemars" > /dev/null pushd "$REPO_DIR/hashes/extended_tests/schemars" > /dev/null
# This comment mentions Rust 1.63 to assist grepping when doing MSRV update.
#
if cargo --version | grep -q '1\.63'; then
cargo update -p regex --precise 1.7.3
fi
cargo test cargo test
popd > /dev/null popd > /dev/null

10
hashes/extended_tests/schemars/README.md
View File

@ -4,10 +4,6 @@ Run as usual with `cargo test`.
## Minimum Supported Rust Version (MSRV) ## Minimum Supported Rust Version (MSRV)
To run the tests with the MSRV you will need to pin `serde`: To run the tests with the current MSRV you will need to pin some
dependencies. See the `hashes/contrib/extra_tests.sh` script for the
```bash current list of pins.
cargo update -p serde --precise 1.0.156
cargo update -p regex --precise 1.7.3
cargo update -p chrono --precise 0.4.24
```