milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#4307: Rename 'indecies' to 'indices' in bip_174.rs for correct terminology 

c55da5c342 Update bip_174.rs (fuder.eth)

Pull request description:

  This pull request renames the variable 'indecies' to 'indices' throughout the bip_174.rs file to use the correct plural form of 'index'. The change affects both variable names and comments, ensuring consistent and proper terminology throughout the codebase.

  Changes include:
  - Renamed 'indecies' to 'indices' in comments
  - Renamed the variable declaration and all references
  - Updated the for loop iteration

  This is a simple terminology correction with no functional changes to the code.

ACKs for top commit:
  tcharding:
    ACK c55da5c342
  apoelstra:
    ACK c55da5c3427ff2d850feb2e5891ce5d52cc304ba; successfully ran local tests; lol

Tree-SHA512: 04249c13599824dc56ea8b86ca1b989bc727cad16f771100e1af00017e3c11559a8dd9fc906569bebed94e36119ff4086cc806dda3b7606c011c5bc95f1398b6
This commit is contained in:
merge-script 2025-04-07 13:26:23 +00:00
parent 7307c115e8 c55da5c342
commit 372f376997
No known key found for this signature in database
GPG Key ID: C588D63CE41B97C1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bitcoin/tests/bip_174.rs
View File

@ -263,15 +263,15 @@ fn update_psbt(mut psbt: Psbt, fingerprint: Fingerprint) -> Psbt {
psbt
}
/// `pk_path` holds tuples of `(public_key, derivation_path)`. `indecies` is used to access the
/// `pk_path` holds tuples of `(public_key, derivation_path)`. `indices` is used to access the
/// `pk_path` vector. `fingerprint` is from the parent extended public key.
fn bip32_derivation(
fingerprint: Fingerprint,
pk_path: &[(&str, &str)],
indecies: Vec<usize>,
indices: Vec<usize>,
) -> BTreeMap<secp256k1::PublicKey, KeySource> {
let mut tree = BTreeMap::new();
for i in indecies {
for i in indices {
let pk = pk_path[i].0;
let path = pk_path[i].1;