milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#749: Re-export SigHashType in lib.rs 

3eea63e42b Re-export SigHashType in lib.rs (sanket1729)

Pull request description:

  Using the latest version of rust-bitcoin master on rust-miniscript
  errors on bitcoin::SigHashType not found. In the original PR, I only
  renamed the export to ECDSASigHashType, but original re-export should
  also be there in lib.rs to avoid breaking changes downstream.

  Fixup to #702

  Before this PR,

  ```
     |
  89 |         required: bitcoin::SigHashType,
     |                            ^^^^^^^^^^^ not found in `bitcoin

  ```

  After this PR,

  ```
  warning: use of deprecated type alias `bitcoin::SigHashType`: Please use [`EcdsaSigHashType`] instead
    --> src/psbt/mod.rs:89:28
     |
  89 |         required: bitcoin::SigHashType,

  ```

ACKs for top commit:
  apoelstra:
    ACK 3eea63e42b
  RCasatta:
    ACK 3eea63e42b

Tree-SHA512: 9cb8683835828e316ffa782c2a249559b4e534aa251b61667f3512b4e872fd88c726615c626ed9abf2061d31dc815ee77bb3d064962c93d0e0befd722fc2ceeb
This commit is contained in:
Riccardo Casatta 2021-12-27 10:07:55 +01:00
parent f9b3fc9ce8 3eea63e42b
commit 38f93605d1
No known key found for this signature in database
GPG Key ID: FD986A969E450397
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib.rs
View File

@ -141,6 +141,8 @@ pub use util::schnorr::{self, SchnorrSig, SchnorrSigError};
pub use util::ecdsa::PrivateKey;
#[deprecated(since = "0.26.1", note = "Please use `ecdsa::PublicKey` instead")]
pub use util::ecdsa::PublicKey;
#[allow(deprecated)]
pub use blockdata::transaction::SigHashType;
#[cfg(feature = "std")]
use std::io;