milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Reduce the FeeRate::MAX value 

In preparation for changing the internal representation of `FeeRate` to
use MvB reduce the max value by 4_000.

Done separately to make the change explicit.
This commit is contained in:
Tobin C. Harding 2025-05-21 08:57:15 +10:00
parent d174c06a4a
commit 399bca531c
No known key found for this signature in database
GPG Key ID: 0AEF0A899E41F7DD
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bitcoin/src/blockdata/transaction.rs
View File

@ -1700,7 +1700,8 @@ mod tests {
fn effective_value_fee_rate_does_not_overflow() { fn effective_value_fee_rate_does_not_overflow() {
let eff_value = let eff_value =
effective_value(FeeRate::MAX, InputWeightPrediction::P2WPKH_MAX, Amount::ZERO); effective_value(FeeRate::MAX, InputWeightPrediction::P2WPKH_MAX, Amount::ZERO);
assert_eq!(eff_value, SignedAmount::MIN) let want = SignedAmount::from_sat(-1254378597012250).unwrap(); // U64::MAX / 4_000 because of FeeRate::MAX
assert_eq!(eff_value, want)
} }
#[test] #[test]

4
units/src/fee_rate/mod.rs
View File

@ -30,7 +30,7 @@ impl FeeRate {
pub const MIN: FeeRate = FeeRate::ZERO; pub const MIN: FeeRate = FeeRate::ZERO;
/// Maximum possible value. /// Maximum possible value.
pub const MAX: FeeRate = FeeRate::from_sat_per_kwu(u64::MAX); pub const MAX: FeeRate = FeeRate::from_sat_per_kwu(u64::MAX / 4_000);
/// Minimum fee rate required to broadcast a transaction. /// Minimum fee rate required to broadcast a transaction.
/// ///
@ -271,7 +271,7 @@ mod tests {
fn fee_rate_const() { fn fee_rate_const() {
assert_eq!(FeeRate::ZERO.to_sat_per_kwu_floor(), 0); assert_eq!(FeeRate::ZERO.to_sat_per_kwu_floor(), 0);
assert_eq!(FeeRate::MIN.to_sat_per_kwu_floor(), u64::MIN); assert_eq!(FeeRate::MIN.to_sat_per_kwu_floor(), u64::MIN);
assert_eq!(FeeRate::MAX.to_sat_per_kwu_floor(), u64::MAX); assert_eq!(FeeRate::MAX.to_sat_per_kwu_floor(), u64::MAX / 4_000);
assert_eq!(FeeRate::BROADCAST_MIN.to_sat_per_kwu_floor(), 250); assert_eq!(FeeRate::BROADCAST_MIN.to_sat_per_kwu_floor(), 250);
assert_eq!(FeeRate::DUST.to_sat_per_kwu_floor(), 750); assert_eq!(FeeRate::DUST.to_sat_per_kwu_floor(), 750);
} }