milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Use to_be_bytes 

Now that MSRV is > 1.32 we can use `u16::to_be_bytes` to ensure network
byte order when encoding the port number of a `AddrV2Message`.

Remove the TODO and use `to_be_bytes` as suggested.
This commit is contained in:
Tobin C. Harding 2022-07-22 13:35:54 +10:00
parent 2256d4634c
commit 3c2869465b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/network/address.rs
View File

@ -259,9 +259,9 @@ impl Encodable for AddrV2Message {
len += VarInt(self.services.to_u64()).consensus_encode(w)?; len += VarInt(self.services.to_u64()).consensus_encode(w)?;
len += self.addr.consensus_encode(w)?; len += self.addr.consensus_encode(w)?;
// consensus_encode always encodes in LE, and we want to encode in BE. w.write_all(&self.port.to_be_bytes())?;
//TODO `len += io::Write::write(w, &self.port.to_be_bytes())?;` when MSRV >= 1.32 len += 2; // port u16 is two bytes.
len += self.port.swap_bytes().consensus_encode(w)?;
Ok(len) Ok(len)
} }
} }