Merge rust-bitcoin/rust-bitcoin#2658: Use pinned nightly in all the tools

398fc6b73a Update pre-commit hook to use pinned nightly (Tobin C. Harding)
1a85eac01b Move nightly_version file to crate root (Tobin C. Harding)

Pull request description:

  Move the nightly pinning config file out of `.github/` and use it in the pre-commit hook.

ACKs for top commit:
  sanket1729:
    ACK 398fc6b73a
  apoelstra:
    ACK 398fc6b73a

Tree-SHA512: 9b30c7064a43b068399927518732c3f4fe033693a7ad09af33f49b18a31c8965e6d4bb887ee558dd2a8d50b165545eb3de3fa7c415bff27efee5ac97385d27ff

.github/workflows/rust.yml

@@ -19,7 +19,7 @@ jobs:
         uses: actions/checkout@v4
       - name: Read nightly version
         id: read_toolchain
-        run: echo "nightly_version=$(cat .github/nightly-version)" >> $GITHUB_OUTPUT
+        run: echo "nightly_version=$(cat nightly-version)" >> $GITHUB_OUTPUT
       - name: Prepare tests
         id: get_matrix
         run: contrib/get_matrix.sh

githooks/pre-commit

@@ -46,4 +46,4 @@ fi
 git diff-index --check --cached $against -- || exit 1
 
 # Check that code lints cleanly.
-cargo +nightly clippy --all-features -- -D warnings || exit 1
+cargo +$(cat ./nightly-version) clippy --workspace --all-targets --all-features -- --deny warnings || exit 1

justfile

@@ -11,11 +11,11 @@ check:
 
 # Lint everything.
 lint:
-  cargo +$(cat .github/nightly-version) clippy --workspace --all-targets --all-features -- --deny warnings
+  cargo +$(cat ./nightly-version) clippy --workspace --all-targets --all-features -- --deny warnings
 
 # Check the formatting
 format:
-  cargo +$(cat .github/nightly-version) fmt --all --check
+  cargo +$(cat ./nightly-version) fmt --all --check
 
 # Quick and dirty CI useful for pre-push checks.
 sane: lint