From 1d13020129669a4435941bef0eb680ba718a1b14 Mon Sep 17 00:00:00 2001 From: yancy Date: Sat, 10 Feb 2024 12:30:47 +0100 Subject: [PATCH] test: Add conditional check for debug_assertions Adding debug_assertions where the test case panics allows the test suite to run in release mode successfully. --- bitcoin/src/bip152.rs | 1 + bitcoin/src/blockdata/fee_rate.rs | 1 + bitcoin/src/blockdata/weight.rs | 1 + bitcoin/src/pow.rs | 5 +++++ 4 files changed, 8 insertions(+) diff --git a/bitcoin/src/bip152.rs b/bitcoin/src/bip152.rs index 5171b859..265339ad 100644 --- a/bitcoin/src/bip152.rs +++ b/bitcoin/src/bip152.rs @@ -489,6 +489,7 @@ mod test { } #[test] + #[cfg(debug_assertions)] #[should_panic] // 'attempt to add with overflow' in consensus_encode() fn test_getblocktx_panic_when_encoding_u64_max() { serialize(&BlockTransactionsRequest { diff --git a/bitcoin/src/blockdata/fee_rate.rs b/bitcoin/src/blockdata/fee_rate.rs index aa8d3c44..4f4d081c 100644 --- a/bitcoin/src/blockdata/fee_rate.rs +++ b/bitcoin/src/blockdata/fee_rate.rs @@ -190,6 +190,7 @@ mod tests { } #[test] + #[cfg(debug_assertions)] #[should_panic] fn from_sat_per_vb_unchecked_panic_test() { FeeRate::from_sat_per_vb_unchecked(u64::MAX); } diff --git a/bitcoin/src/blockdata/weight.rs b/bitcoin/src/blockdata/weight.rs index 4843685e..7cd42064 100644 --- a/bitcoin/src/blockdata/weight.rs +++ b/bitcoin/src/blockdata/weight.rs @@ -182,6 +182,7 @@ mod tests { } #[test] + #[cfg(debug_assertions)] #[should_panic] fn from_vb_unchecked_panic() { Weight::from_vb_unchecked(u64::MAX); } diff --git a/bitcoin/src/pow.rs b/bitcoin/src/pow.rs index 7af2bb61..c3d53371 100644 --- a/bitcoin/src/pow.rs +++ b/bitcoin/src/pow.rs @@ -1692,22 +1692,27 @@ mod tests { } #[test] + #[cfg(debug_assertions)] #[should_panic] fn u256_overflowing_addition_panics() { let _ = U256::MAX + U256::ONE; } #[test] + #[cfg(debug_assertions)] #[should_panic] fn u256_overflowing_subtraction_panics() { let _ = U256::ZERO - U256::ONE; } #[test] + #[cfg(debug_assertions)] #[should_panic] fn u256_multiplication_by_max_panics() { let _ = U256::MAX * U256::MAX; } #[test] + #[cfg(debug_assertions)] #[should_panic] fn work_overflowing_addition_panics() { let _ = Work(U256::MAX) + Work(U256::ONE); } #[test] + #[cfg(debug_assertions)] #[should_panic] fn work_overflowing_subtraction_panics() { let _ = Work(U256::ZERO) - Work(U256::ONE); }