diff --git a/bitcoin/src/consensus/serde.rs b/bitcoin/src/consensus/serde.rs index 143851a62..790dd5781 100644 --- a/bitcoin/src/consensus/serde.rs +++ b/bitcoin/src/consensus/serde.rs @@ -159,7 +159,6 @@ struct DisplayWrapper<'a, T: 'a + Encodable, E>(&'a T, PhantomData); impl<'a, T: 'a + Encodable, E: ByteEncoder> fmt::Display for DisplayWrapper<'a, T, E> { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { let mut writer = IoWrapper::<'_, _, E::Encoder>::new(f, E::default().into()); - #[allow(unused_variables)] // When debug_assertions are not enabled. self.0.consensus_encode(&mut writer).map_err(|error| { #[cfg(debug_assertions)] { @@ -174,6 +173,8 @@ impl<'a, T: 'a + Encodable, E: ByteEncoder> fmt::Display for DisplayWrapper<'a, ); } } + #[cfg(not(debug_assertions))] + let _ = error; fmt::Error })?; let result = writer.actually_flush(); @@ -200,7 +201,6 @@ impl ErrorTrackingWriter { } #[track_caller] - #[allow(unused_variables)] // When debug_assertions are not enabled. fn assert_no_error(&self, fun: &str) { #[cfg(debug_assertions)] { @@ -208,6 +208,8 @@ impl ErrorTrackingWriter { panic!("`{}` called on errored writer", fun); } } + #[cfg(not(debug_assertions))] + let _ = fun; } fn assert_was_error(&self) { @@ -219,12 +221,13 @@ impl ErrorTrackingWriter { } } - #[allow(unused_variables)] // When debug_assertions are not enabled. fn set_error(&mut self, was: bool) { #[cfg(debug_assertions)] { self.was_error |= was; } + #[cfg(not(debug_assertions))] + let _ = was; } fn check_err(&mut self, result: Result) -> Result {