From b7f11d4493f8894ec4c91ea753e900c57e7718d9 Mon Sep 17 00:00:00 2001 From: Steven Roose Date: Mon, 23 Oct 2023 01:36:19 +0100 Subject: [PATCH 1/3] Remove unnecessary clippy attribute on absolute::LockTime I ran the clippy locally without it and it doesn't seem to be necessary anymore. --- bitcoin/src/blockdata/locktime/absolute.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/bitcoin/src/blockdata/locktime/absolute.rs b/bitcoin/src/blockdata/locktime/absolute.rs index 5f5a27bd..c6a9e112 100644 --- a/bitcoin/src/blockdata/locktime/absolute.rs +++ b/bitcoin/src/blockdata/locktime/absolute.rs @@ -66,7 +66,6 @@ pub const LOCK_TIME_THRESHOLD: u32 = 500_000_000; /// _ => panic!("handle invalid comparison error"), /// }; /// ``` -#[allow(clippy::derive_ord_xor_partial_ord)] #[derive(Clone, Copy, PartialEq, Eq, Hash)] pub enum LockTime { /// A block height lock time value. From f522a0290c92663b27d0f62c74517914653e593a Mon Sep 17 00:00:00 2001 From: Steven Roose Date: Mon, 23 Oct 2023 01:37:50 +0100 Subject: [PATCH 2/3] Remove unnecessary clippy attribute on relative::LockTime --- bitcoin/src/blockdata/locktime/relative.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/bitcoin/src/blockdata/locktime/relative.rs b/bitcoin/src/blockdata/locktime/relative.rs index fca20938..198091de 100644 --- a/bitcoin/src/blockdata/locktime/relative.rs +++ b/bitcoin/src/blockdata/locktime/relative.rs @@ -26,7 +26,6 @@ use crate::relative; /// /// * [BIP 68 Relative lock-time using consensus-enforced sequence numbers](https://github.com/bitcoin/bips/blob/master/bip-0065.mediawiki) /// * [BIP 112 CHECKSEQUENCEVERIFY](https://github.com/bitcoin/bips/blob/master/bip-0112.mediawiki) -#[allow(clippy::derive_ord_xor_partial_ord)] #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] #[cfg_attr(feature = "serde", serde(crate = "actual_serde"))] From 750ee2ba565e4ea79164b93b3547f7ad85d3e2c1 Mon Sep 17 00:00:00 2001 From: Steven Roose Date: Mon, 23 Oct 2023 01:41:44 +0100 Subject: [PATCH 3/3] Remove unnecessary clippy attribute on is_sighash_single_bug --- bitcoin/src/crypto/sighash.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/bitcoin/src/crypto/sighash.rs b/bitcoin/src/crypto/sighash.rs index 912f87fe..6dcb6e62 100644 --- a/bitcoin/src/crypto/sighash.rs +++ b/bitcoin/src/crypto/sighash.rs @@ -1237,7 +1237,6 @@ impl EncodeSigningDataResult { /// // use a hash value of "1", instead of computing the actual hash due to SIGHASH_SINGLE bug /// } /// ``` - #[allow(clippy::wrong_self_convention)] // E is not Copy so we consume self. pub fn is_sighash_single_bug(self) -> Result { match self { EncodeSigningDataResult::SighashSingleBug => Ok(true),