From 50e772fe7921f3b73858f857aa049839a118122c Mon Sep 17 00:00:00 2001 From: Andrew Poelstra Date: Wed, 20 Mar 2024 14:08:17 +0000 Subject: [PATCH] Revert "ci: introduce `classify-pr.sh` script which determines whether a PR should have CI run" This reverts commit 9aca8a18c7fdd8c1e873429553e401805f794013. --- .github/workflows/rust.yml | 4 ---- contrib/classify-pr.sh | 25 ------------------------- 2 files changed, 29 deletions(-) delete mode 100755 contrib/classify-pr.sh diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 4a5174d3..169e2e5f 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -14,13 +14,9 @@ jobs: crates: ${{ steps.get_matrix.outputs.crates }} deps: ${{ steps.get_matrix.outputs.deps }} nightly_version: ${{ steps.read_toolchain.outputs.nightly_version }} - pr_changed_source: ${{ steps.classify_pr.outputs.pr_changed_source }} steps: - name: Checkout Crate uses: actions/checkout@v4 - - name: Determine what files the PR changes. - id: classify_pr - run: contrib/classify-pr.sh ${{ github.event.pull_request.head.sha }} ${{ github.event.pull_request.base.sha }} - name: Read nightly version id: read_toolchain run: echo "nightly_version=$(cat .github/nightly-version)" >> $GITHUB_OUTPUT diff --git a/contrib/classify-pr.sh b/contrib/classify-pr.sh deleted file mode 100755 index 0cab8cce..00000000 --- a/contrib/classify-pr.sh +++ /dev/null @@ -1,25 +0,0 @@ -#!/bin/sh - -if [ "$#" -ne 2 ]; then - echo "Usage: $0 " - exit 1 -fi - -pr_tip=$1 -master_tip=$2 - -# When called on `pull_request`, GA fails to pull down master by default. -# When called on `push`, GA fails to pull down the PR by default, only its merge commit. -# The simplest way to deal with this is to just pull both explicitly. -git fetch origin "$master_tip":master_tip -git fetch origin "$pr_tip":pr_tip - -pr_base=$(git merge-base master_tip pr_tip) - -# If something modifies any non-markdown file, it's considered a source code change. -if git diff --name-only "$pr_base" "$pr_tip" | grep -qv "^.md$"; then - echo "pr_changed_source=true" >> "$GITHUB_OUTPUT" -else - echo "pr_changed_source=false" >> "$GITHUB_OUTPUT" -fi -