From 33ebbac4c8ead67243131e6e8ad4f25d0796af6d Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Wed, 10 Apr 2024 11:03:20 +1000 Subject: [PATCH] Improve deprecation notice The deprecation notice for `is_provably_unspendable` contains "is not very useful" which is a bit presumptuous to tell to users, it may very well be useful to them. Use the more helpful text that already exists in rustdoc on the function. --- bitcoin/src/blockdata/script/borrowed.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bitcoin/src/blockdata/script/borrowed.rs b/bitcoin/src/blockdata/script/borrowed.rs index 253c38f1..f07858d2 100644 --- a/bitcoin/src/blockdata/script/borrowed.rs +++ b/bitcoin/src/blockdata/script/borrowed.rs @@ -359,7 +359,7 @@ impl Script { /// removed. Use `is_op_return` if you want `OP_RETURN` semantics. #[deprecated( since = "0.32.0", - note = "The method is not very useful, you might want `is_op_return`" + note = "The method has potentially confusing semantics and is going to be removed, you might want `is_op_return`" )] #[inline] pub fn is_provably_unspendable(&self) -> bool {