milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#3656: Fix typo in hash tag type 

d9ccb60a2f Fix typo in hash tag type (Tobin C. Harding)

Pull request description:

  In commit: `39f7dcb Reduce API surface of tagged wrapped hash types` I introduced a typo in the tagged hash tag type. Fortunately it has no effect because the tag type controls how an engine  is created (when the tag is input into the engine) and has no effect on the call to `from_engine`. However the typo makes the code confusing.

  This bug is currently unreleased.

  Fix: #3649

ACKs for top commit:
  apoelstra:
    ACK d9ccb60a2f9e89c8bb1979f032e8a222ab9b025a; successfully ran local tests

Tree-SHA512: 54cc78fb74ea119beaf4500d49a4d3954ffc3c52494b3ebc1539a3eec35078cb9388e72b42c59f371b53cced89b7b6303a0e3d3b02e59d72da182dd7bbfe2a55
This commit is contained in:
merge-script 2024-11-26 19:20:48 +00:00
parent 3aed196983 d9ccb60a2f
commit 5958b0f8b8
No known key found for this signature in database
GPG Key ID: C588D63CE41B97C1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bitcoin/src/taproot/mod.rs
View File

@ -68,7 +68,7 @@ crate::internal_macros::define_extension_trait! {
let mut eng = sha256t::Hash::<TapLeafTag>::engine();
ver.to_consensus().consensus_encode(&mut eng).expect("engines don't error");
script.consensus_encode(&mut eng).expect("engines don't error");
let inner = sha256t::Hash::<TapTweakTag>::from_engine(eng);
let inner = sha256t::Hash::<TapLeafTag>::from_engine(eng);
TapLeafHash::from_byte_array(inner.to_byte_array())
}
}