milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Fix `is_invalid_use_of_sighash_single()` incompatibility with Bitcoin Core

This commit is contained in:
Liu-Cheng Xu 2025-02-25 07:40:46 +08:00
parent 0157dc21c3
commit 5d38073afb
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
bitcoin/src/crypto/sighash.rs
View File

@ -429,6 +429,16 @@ impl EcdsaSighashType {
}
}
/// Checks if the sighash type is [`Self::Single`] or [`Self::SinglePlusAnyoneCanPay`].
///
/// This matches Bitcoin Core's behavior where SIGHASH_SINGLE bug check is based on the base
/// type (after masking with 0x1f), regardless of the ANYONECANPAY flag.
///
/// See: <https://github.com/bitcoin/bitcoin/blob/e486597/src/script/interpreter.cpp#L1618-L1619>
pub fn is_single(&self) -> bool {
matches!(self, Self::Single | Self::SinglePlusAnyoneCanPay)
}
/// Constructs a new [`EcdsaSighashType`] from a raw `u32`.
///
/// **Note**: this replicates consensus behaviour, for current standardness rules correctness
@ -1360,7 +1370,7 @@ impl std::error::Error for AnnexError {
fn is_invalid_use_of_sighash_single(sighash: u32, input_index: usize, outputs_len: usize) -> bool {
let ty = EcdsaSighashType::from_consensus(sighash);
ty == EcdsaSighashType::Single && input_index >= outputs_len
ty.is_single() && input_index >= outputs_len
}
/// Result of [`SighashCache::legacy_encode_signing_data_to`].