diff --git a/fuzz/Cargo.toml b/fuzz/Cargo.toml index 8923ac47..16641da9 100644 --- a/fuzz/Cargo.toml +++ b/fuzz/Cargo.toml @@ -55,3 +55,7 @@ path = "fuzz_targets/outpoint_string.rs" [[bin]] name = "deserialize_psbt" path = "fuzz_targets/deserialize_psbt.rs" + +[[bin]] +name = "deser_net_msg" +path = "fuzz_targets/deser_net_msg.rs" diff --git a/fuzz/fuzz_targets/deser_net_msg.rs b/fuzz/fuzz_targets/deser_net_msg.rs new file mode 100644 index 00000000..e2c1a0a7 --- /dev/null +++ b/fuzz/fuzz_targets/deser_net_msg.rs @@ -0,0 +1,52 @@ +extern crate bitcoin; + +fn do_test(data: &[u8]) { + let _: Result = bitcoin::consensus::encode::deserialize(data); +} + +#[cfg(feature = "afl")] +#[macro_use] extern crate afl; +#[cfg(feature = "afl")] +fn main() { + fuzz!(|data| { + do_test(&data); + }); +} + +#[cfg(feature = "honggfuzz")] +#[macro_use] extern crate honggfuzz; +#[cfg(feature = "honggfuzz")] +fn main() { + loop { + fuzz!(|data| { + do_test(data); + }); + } +} + +#[cfg(test)] +mod tests { + fn extend_vec_from_hex(hex: &str, out: &mut Vec) { + let mut b = 0; + for (idx, c) in hex.as_bytes().iter().enumerate() { + b <<= 4; + match *c { + b'A'...b'F' => b |= c - b'A' + 10, + b'a'...b'f' => b |= c - b'a' + 10, + b'0'...b'9' => b |= c - b'0', + _ => panic!("Bad hex"), + } + if (idx & 1) == 1 { + out.push(b); + b = 0; + } + } + } + + #[test] + fn duplicate_crash() { + let mut a = Vec::new(); + extend_vec_from_hex("00", &mut a); + super::do_test(&a); + } +} diff --git a/fuzz/travis-fuzz.sh b/fuzz/travis-fuzz.sh index 3af8d1aa..731e52f4 100755 --- a/fuzz/travis-fuzz.sh +++ b/fuzz/travis-fuzz.sh @@ -7,7 +7,7 @@ for TARGET in fuzz_targets/*; do if [ -d hfuzz_input/$FILE ]; then HFUZZ_INPUT_ARGS="-f hfuzz_input/$FILE/input" fi - HFUZZ_BUILD_ARGS="--features honggfuzz_fuzz" HFUZZ_RUN_ARGS="-N200000 --exit_upon_crash -v $HFUZZ_INPUT_ARGS" cargo hfuzz run $FILE + HFUZZ_BUILD_ARGS="--features honggfuzz_fuzz" HFUZZ_RUN_ARGS="--run_time 30 --exit_upon_crash -v $HFUZZ_INPUT_ARGS" cargo hfuzz run $FILE if [ -f hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT ]; then cat hfuzz_workspace/$FILE/HONGGFUZZ.REPORT.TXT diff --git a/src/consensus/encode.rs b/src/consensus/encode.rs index 90e4d2f1..7620137a 100644 --- a/src/consensus/encode.rs +++ b/src/consensus/encode.rs @@ -659,6 +659,12 @@ impl Decodable for CheckedData { #[inline] fn consensus_decode(d: &mut D) -> Result { let len: u32 = Decodable::consensus_decode(d)?; + if len > MAX_VEC_SIZE as u32 { + return Err(self::Error::OversizedVectorAllocation { + requested: len as usize, + max: MAX_VEC_SIZE + }); + } let checksum: [u8; 4] = Decodable::consensus_decode(d)?; let mut ret = Vec::with_capacity(len as usize); ret.resize(len as usize, 0);