milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#1125: Update docs on rustfmt 

b7eea6cb26 Update docs on rustfmt (Tobin C. Harding)

Pull request description:

  We have introduced `rustfmt` but forgot to update the docs section about
  it. Since a large portion of the codebase is currently ignored by our
  `rustfmt` configuration, point out that `rusntfmt` is work in progress.

ACKs for top commit:
  apoelstra:
    ACK b7eea6cb26
  Kixunil:
    ACK b7eea6cb26

Tree-SHA512: c3a01e38e9787f7554847c657de8d2aeb512f237f68e97973ffa04e92decd282126abf16edb369c13dbeb9eed3587e20dbfb3ab77e06551a006a7aa2c70a71ad
This commit is contained in:
Andrew Poelstra 2022-09-14 13:22:10 +00:00
parent 3b59b3b266 b7eea6cb26
commit 779668879d
No known key found for this signature in database
GPG Key ID: C588D63CE41B97C1
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
CONTRIBUTING.md
View File

@ -170,18 +170,9 @@ Library reflects Bitcoin Core approach whenever possible.
### Formatting
The repository currently does not use `rustfmt`.
New changes may format the code with `rustfmt`, but they should not re-format
any existing code for maintaining diff size small, keeping `git blame` intact and
reduce review time. Repository maintainers may not review PRs introducing large
blocks of re-formatted code.
You may check the [discussion on the formatting](https://github.com/rust-bitcoin/rust-bitcoin/issues/172)
and [how it is planned to coordinate it with crate refactoring](https://github.com/rust-bitcoin/rust-bitcoin/pull/525)
For the new code it is recommended to follow style of the existing codebase and
avoid any end-line space characters.
The repository currently does use `rustfmt`. The introduction of this is still
WIP (see 'ignore' in `rustfmt.toml`) but we are working towards full
formatting.
### Naming conventions