milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#2384: Remove `serde-std` from `hashes` 

1c4614ea30 hashes: Remove serde-std feature (Tobin C. Harding)

Pull request description:

  As we do for "rand-std" in the `bitcoin` crate we can enable "std" when the "serde-std" feature is enabled. This makes the features more explicit and arguably more ergonomic.

  Found while working on #2353, no additional testing added hear (in CI).

ACKs for top commit:
  Kixunil:
    ACK 1c4614ea30
  apoelstra:
    ACK 1c4614ea30

Tree-SHA512: b82b72eacdd84cca076747a0eb0c7a625ec6f918701699ca7e7159e0606b089c80182e9d54e1d48b2957815883a36dfa337e353573a6ffe4fa19458615111080
This commit is contained in:
Andrew Poelstra 2024-01-24 15:10:43 +00:00
parent 434773d993 1c4614ea30
commit 7a1f5e4b4d
No known key found for this signature in database
GPG Key ID: C588D63CE41B97C1
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hashes/Cargo.toml
View File

@ -17,7 +17,6 @@ exclude = ["tests", "contrib"]
default = ["std"] default = ["std"]
std = ["alloc", "hex/std", "bitcoin-io/std"] std = ["alloc", "hex/std", "bitcoin-io/std"]
alloc = ["hex/alloc"] alloc = ["hex/alloc"]
serde-std = ["serde/std"]
# If you want I/O you must enable either "std" or "io". # If you want I/O you must enable either "std" or "io".
io = ["bitcoin-io"] io = ["bitcoin-io"]
# Smaller (but slower) implementation of sha256, sha512 and ripemd160 # Smaller (but slower) implementation of sha256, sha512 and ripemd160
@ -32,7 +31,6 @@ hex = { package = "hex-conservative", version = "0.1.1", default-features = fals
bitcoin-io = { version = "0.1", default-features = false, optional = true } bitcoin-io = { version = "0.1", default-features = false, optional = true }
schemars = { version = "0.8.3", default-features = false, optional = true } schemars = { version = "0.8.3", default-features = false, optional = true }
# Only enable this if you explicitly do not want to use "std", otherwise enable "serde-std".
serde = { version = "1.0", default-features = false, optional = true } serde = { version = "1.0", default-features = false, optional = true }
[dev-dependencies] [dev-dependencies]

2
hashes/contrib/test.sh
View File

@ -2,7 +2,7 @@
set -ex set -ex
FEATURES="serde serde-std std io alloc" FEATURES="serde std io alloc"
cargo --version cargo --version
rustc --version rustc --version