milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Re-name TweakedPublicKey constructor 

Keeping inline with the method on `UntweakedPublicKey` that outputs a
`TweakedPublicKey` we can use the same name, for the same reasons.

Use `dangerous_assume_tweaked` as the constructor name to highlight the
fact that this constructor should probably not be being used.
This commit is contained in:
Tobin Harding 2021-12-02 14:40:24 +11:00
parent 3c3cf0396b
commit 7af0999745
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/util/schnorr.rs
View File

@ -65,8 +65,9 @@ impl TapTweak for UntweakedPublicKey {
impl TweakedPublicKey {
/// Create a new [TweakedPublicKey] from a [PublicKey]. No tweak is applied.
pub fn new(key: PublicKey) -> TweakedPublicKey {
/// Creates a new [`TweakedPublicKey`] from a [`PublicKey`]. No tweak is applied, consider
/// calling `tap_tweak` on an [`UntweakedPublicKey`] instead of using this constructor.
pub fn dangerous_assume_tweaked(key: PublicKey) -> TweakedPublicKey {
TweakedPublicKey(key)
}

4
src/util/taproot.rs
View File

@ -268,7 +268,7 @@ impl TaprootSpendInfo {
internal_key: internal_key,
merkle_root: merkle_root,
output_key_parity: parity,
output_key: TweakedPublicKey::new(output_key),
output_key: TweakedPublicKey::dangerous_assume_tweaked(output_key),
script_map: BTreeMap::new(),
}
}
@ -985,7 +985,7 @@ mod test {
fn _verify_tap_commitments(secp: &Secp256k1<VerifyOnly>, out_spk_hex: &str, script_hex : &str, control_block_hex: &str) {
let out_pk = schnorr::PublicKey::from_str(&out_spk_hex[4..]).unwrap();
let out_pk = TweakedPublicKey::new(out_pk);
let out_pk = TweakedPublicKey::dangerous_assume_tweaked(out_pk);
let script = Script::from_hex(script_hex).unwrap();
let control_block = ControlBlock::from_slice(&Vec::<u8>::from_hex(control_block_hex).unwrap()).unwrap();
assert_eq!(control_block_hex, control_block.serialize().to_hex());