milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#4654: Remove match arm and guard mutant exclusion 

13c5df083d Enhance the weekly mutation workflow markdown (user)
63b61e9497 Remove delete match arm and match guard mutation exclusion (user)

Pull request description:

  Closes #4653
  
  This removes the delete match arm and match guard exclusion as these mutations can now be targeted individually.
  
  ~~In draft as I have yet to run the mutations locally to add any exclusions that may still need to be added~~


ACKs for top commit:
  jamillambert:
    ACK 13c5df083d
  tcharding:
    ACK 13c5df083d
  apoelstra:
    ACK 13c5df083d6761c5780fc998e33ba4d38d45edf6; successfully ran local tests; lgtm


Tree-SHA512: 60a9741a101dae970dba040776c0a635bb697dd1f0ae6baee8131544703fbeeea3d03884b86fbd5710681ff07a83ab4afa94b97a4f925787351baf72a93dd7cb
This commit is contained in:
Andrew Poelstra 2025-07-04 13:22:42 +00:00
parent 9b4daa4192 13c5df083d
commit 7ba49d6552
No known key found for this signature in database
GPG Key ID: C588D63CE41B97C1
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.cargo/mutants.toml
View File

@ -10,7 +10,6 @@ exclude_re = [
".*Error", ".*Error",
"deserialize", # Skip serde mutation tests "deserialize", # Skip serde mutation tests
"Iterator", # Mutating operations in an iterator can result in an infinite loop "Iterator", # Mutating operations in an iterator can result in an infinite loop
"match arm", "match guard", # New addition in cargo-mutants 25.0.1 deletes match arms and replaces match guards even in excluded functions
# ----------------------------------Crate-specific exclusions---------------------------------- # ----------------------------------Crate-specific exclusions----------------------------------
# Units # Units

6
.github/workflows/cron-weekly-cargo-mutants.yml vendored
View File

@ -22,13 +22,15 @@ jobs:
run: | run: |
if [ -s mutants.out/missed.txt ]; then if [ -s mutants.out/missed.txt ]; then
echo "New missed mutants found" echo "New missed mutants found"
MUTANTS_VERSION=$(cargo mutants --version)
gh issue create \ gh issue create \
--title "New Mutants Found" \ --title "New Mutants Found" \
--body "$(cat <<EOF --body "$(cat <<EOF
Displaying up to the first 10 mutants: Displaying up to the first 10 mutants:
\`\`\`
$(head -n 10 mutants.out/missed.txt) $(head -n 10 mutants.out/missed.txt)
\`\`\`
Running cargo mutants version: ${MUTANTS_VERSION}
For the complete list, please check the [mutants.out artifact](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}). For the complete list, please check the [mutants.out artifact](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}).
EOF EOF
)" )"