milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Show output of failed semver checks 

Debugging the API breaks without seeing what failed is pretty much
impossible. This simply prints the output when a check fails.
This commit is contained in:
Martin Habovstiak 2024-08-27 20:01:32 +02:00
parent 1058cbb9f8
commit 83831e6363
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/semver-checks-pr-label.yml vendored
View File

@ -73,7 +73,7 @@ jobs:
owner: context.repo.owner, owner: context.repo.owner,
repo: context.repo.repo, repo: context.repo.repo,
issue_number: issue_number, issue_number: issue_number,
body: ':rotating_light: API BREAKING CHANGE DETECTED' body: ':rotating_light: API BREAKING CHANGE DETECTED\n\nTo see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section.'
}); });
// add the label to the PR // add the label to the PR

1
contrib/check-semver-feature.sh
View File

@ -112,6 +112,7 @@ check_for_non_additive_cargo_features() {
if grep -q "FAIL" "$file"; then if grep -q "FAIL" "$file"; then
echo "You have introduced non-additive cargo features" echo "You have introduced non-additive cargo features"
echo "FAIL found in $file" echo "FAIL found in $file"
cat "$file"
# flag it as a breaking change # flag it as a breaking change
# Handle the case where FAIL is found # Handle the case where FAIL is found
touch non-additive-cargo touch non-additive-cargo

1
contrib/check-semver-pr.sh
View File

@ -175,6 +175,7 @@ check_for_breaking_changes() {
if grep -q "FAIL" "$file"; then if grep -q "FAIL" "$file"; then
echo "You have introduced changes to the public API" echo "You have introduced changes to the public API"
echo "FAIL found in $file" echo "FAIL found in $file"
cat "$file"
# flag it as a breaking change # flag it as a breaking change
# Handle the case where FAIL is found # Handle the case where FAIL is found
touch semver-break touch semver-break