From beea3c1e5d9b8ea9970ac6a4c4d4cde3462f83ef Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Wed, 17 Jul 2024 06:50:42 +1000 Subject: [PATCH] Remove public error re-export We do not have a policy to re-export things from other modules just because they are in the public API - I don't see any other reason to re-export this error, users should go to the `validation` module directly to get the error type. --- bitcoin/src/blockdata/transaction.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/bitcoin/src/blockdata/transaction.rs b/bitcoin/src/blockdata/transaction.rs index ceee9ae69..a589feea8 100644 --- a/bitcoin/src/blockdata/transaction.rs +++ b/bitcoin/src/blockdata/transaction.rs @@ -29,11 +29,6 @@ use crate::sighash::{EcdsaSighashType, TapSighashType}; use crate::witness::Witness; use crate::{Amount, FeeRate, SignedAmount, VarInt}; -#[rustfmt::skip] // Keep public re-exports separate. -#[cfg(feature = "bitcoinconsensus")] -#[doc(inline)] -pub use crate::consensus::validation::TxVerifyError; - hashes::hash_newtype! { /// A bitcoin transaction hash/transaction ID. /// @@ -1846,6 +1841,7 @@ mod tests { fn transaction_verify() { use std::collections::HashMap; + use crate::consensus::validation::TxVerifyError; use crate::witness::Witness; // a random recent segwit transaction from blockchain using both old and segwit inputs