Make 'use core::fmt' calls consistent

This commit is contained in:
Shing Him Ng 2024-06-26 08:51:11 -05:00
parent 9ba29b384e
commit 8ee1744b9b
5 changed files with 26 additions and 27 deletions

View File

@ -38,7 +38,7 @@
//! ``` //! ```
use core::cmp::{self, Ordering}; use core::cmp::{self, Ordering};
use core::fmt::{self, Display, Formatter}; use core::fmt;
use hashes::{sha256d, siphash24}; use hashes::{sha256d, siphash24};
use internals::write_err; use internals::write_err;
@ -78,8 +78,8 @@ pub enum Error {
internals::impl_from_infallible!(Error); internals::impl_from_infallible!(Error);
impl Display for Error { impl fmt::Display for Error {
fn fmt(&self, f: &mut Formatter) -> Result<(), fmt::Error> { fn fmt(&self, f: &mut fmt::Formatter) -> Result<(), fmt::Error> {
use Error::*; use Error::*;
match *self { match *self {

View File

@ -19,7 +19,6 @@
//! ``` //! ```
use core::fmt; use core::fmt;
use core::fmt::Display;
use core::str::FromStr; use core::str::FromStr;
use internals::write_err; use internals::write_err;
@ -279,7 +278,7 @@ impl fmt::Display for Network {
#[non_exhaustive] #[non_exhaustive]
pub struct UnknownChainHashError(ChainHash); pub struct UnknownChainHashError(ChainHash);
impl Display for UnknownChainHashError { impl fmt::Display for UnknownChainHashError {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
write!(f, "unknown chain hash: {}", self.0) write!(f, "unknown chain hash: {}", self.0)
} }

View File

@ -6,7 +6,7 @@
//! functions here are designed to be fast, by that we mean it is safe to use them to check headers. //! functions here are designed to be fast, by that we mean it is safe to use them to check headers.
use core::cmp; use core::cmp;
use core::fmt::{self, LowerHex, UpperHex}; use core::fmt;
use core::ops::{Add, Div, Mul, Not, Rem, Shl, Shr, Sub}; use core::ops::{Add, Div, Mul, Not, Rem, Shl, Shr, Sub};
use io::{BufRead, Write}; use io::{BufRead, Write};
@ -465,14 +465,14 @@ impl Decodable for CompactTarget {
} }
} }
impl LowerHex for CompactTarget { impl fmt::LowerHex for CompactTarget {
#[inline] #[inline]
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { LowerHex::fmt(&self.0, f) } fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { fmt::LowerHex::fmt(&self.0, f) }
} }
impl UpperHex for CompactTarget { impl fmt::UpperHex for CompactTarget {
#[inline] #[inline]
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { UpperHex::fmt(&self.0, f) } fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { fmt::UpperHex::fmt(&self.0, f) }
} }
/// Big-endian 256 bit integer type. /// Big-endian 256 bit integer type.
@ -976,7 +976,7 @@ impl fmt::Debug for U256 {
} }
macro_rules! impl_hex { macro_rules! impl_hex {
($hex:ident, $case:expr) => { ($hex:path, $case:expr) => {
impl $hex for U256 { impl $hex for U256 {
fn fmt(&self, f: &mut fmt::Formatter) -> core::fmt::Result { fn fmt(&self, f: &mut fmt::Formatter) -> core::fmt::Result {
hex::fmt_hex_exact!(f, 32, &self.to_be_bytes(), $case) hex::fmt_hex_exact!(f, 32, &self.to_be_bytes(), $case)
@ -984,8 +984,8 @@ macro_rules! impl_hex {
} }
}; };
} }
impl_hex!(LowerHex, hex::Case::Lower); impl_hex!(fmt::LowerHex, hex::Case::Lower);
impl_hex!(UpperHex, hex::Case::Upper); impl_hex!(fmt::UpperHex, hex::Case::Upper);
#[cfg(feature = "serde")] #[cfg(feature = "serde")]
impl crate::serde::Serialize for U256 { impl crate::serde::Serialize for U256 {

View File

@ -1141,7 +1141,7 @@ impl std::error::Error for IndexOutOfBoundsError {
#[cfg(feature = "base64")] #[cfg(feature = "base64")]
mod display_from_str { mod display_from_str {
use core::fmt::{self, Display, Formatter}; use core::fmt;
use core::str::FromStr; use core::str::FromStr;
use base64::display::Base64Display; use base64::display::Base64Display;
@ -1162,8 +1162,8 @@ mod display_from_str {
internals::impl_from_infallible!(PsbtParseError); internals::impl_from_infallible!(PsbtParseError);
impl Display for PsbtParseError { impl fmt::Display for PsbtParseError {
fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
use self::PsbtParseError::*; use self::PsbtParseError::*;
match *self { match *self {
@ -1185,8 +1185,8 @@ mod display_from_str {
} }
} }
impl Display for Psbt { impl fmt::Display for Psbt {
fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "{}", Base64Display::new(&self.serialize(), &BASE64_STANDARD)) write!(f, "{}", Base64Display::new(&self.serialize(), &BASE64_STANDARD))
} }
} }

View File

@ -1,6 +1,6 @@
#[cfg(all(not(feature = "std"), feature = "alloc"))] #[cfg(all(not(feature = "std"), feature = "alloc"))]
use alloc::boxed::Box; use alloc::boxed::Box;
use core::fmt::{Debug, Display, Formatter}; use core::fmt;
/// The `io` crate error type. /// The `io` crate error type.
#[derive(Debug)] #[derive(Debug)]
@ -10,7 +10,7 @@ pub struct Error {
#[cfg(feature = "std")] #[cfg(feature = "std")]
error: Option<Box<dyn std::error::Error + Send + Sync + 'static>>, error: Option<Box<dyn std::error::Error + Send + Sync + 'static>>,
#[cfg(all(feature = "alloc", not(feature = "std")))] #[cfg(all(feature = "alloc", not(feature = "std")))]
error: Option<Box<dyn Debug + Send + Sync + 'static>>, error: Option<Box<dyn fmt::Debug + Send + Sync + 'static>>,
} }
impl Error { impl Error {
@ -40,7 +40,7 @@ impl Error {
/// Returns a reference to this error. /// Returns a reference to this error.
#[cfg(all(feature = "alloc", not(feature = "std")))] #[cfg(all(feature = "alloc", not(feature = "std")))]
pub fn get_ref(&self) -> Option<&(dyn Debug + Send + Sync + 'static)> { self.error.as_deref() } pub fn get_ref(&self) -> Option<&(dyn fmt::Debug + Send + Sync + 'static)> { self.error.as_deref() }
} }
impl From<ErrorKind> for Error { impl From<ErrorKind> for Error {
@ -53,8 +53,8 @@ impl From<ErrorKind> for Error {
} }
} }
impl Display for Error { impl fmt::Display for Error {
fn fmt(&self, fmt: &mut Formatter) -> core::result::Result<(), core::fmt::Error> { fn fmt(&self, fmt: &mut fmt::Formatter) -> core::result::Result<(), core::fmt::Error> {
fmt.write_fmt(format_args!("I/O Error: {}", self.kind.description()))?; fmt.write_fmt(format_args!("I/O Error: {}", self.kind.description()))?;
#[cfg(any(feature = "alloc", feature = "std"))] #[cfg(any(feature = "alloc", feature = "std"))]
if let Some(e) = &self.error { if let Some(e) = &self.error {
@ -189,17 +189,17 @@ define_errorkind!(
mod sealed { mod sealed {
use alloc::boxed::Box; use alloc::boxed::Box;
use alloc::string::String; use alloc::string::String;
use core::fmt::Debug; use core::fmt;
pub trait IntoBoxDynDebug { pub trait IntoBoxDynDebug {
fn into(self) -> Box<dyn Debug + Send + Sync + 'static>; fn into(self) -> Box<dyn fmt::Debug + Send + Sync + 'static>;
} }
impl IntoBoxDynDebug for &str { impl IntoBoxDynDebug for &str {
fn into(self) -> Box<dyn Debug + Send + Sync + 'static> { Box::new(String::from(self)) } fn into(self) -> Box<dyn fmt::Debug + Send + Sync + 'static> { Box::new(String::from(self)) }
} }
impl IntoBoxDynDebug for String { impl IntoBoxDynDebug for String {
fn into(self) -> Box<dyn Debug + Send + Sync + 'static> { Box::new(self) } fn into(self) -> Box<dyn fmt::Debug + Send + Sync + 'static> { Box::new(self) }
} }
} }