milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Use "unfinalized" in header of Midstate 

The midstate has not been finalized [0], so use the term in the struct
header.

FTR I don't know _exactly_ what "finalized" means in the context of
sha256 hashing (or hashing in general). This change came from a review
suggestion and we have other mentions of "finalized" in the code.
This commit is contained in:
Tobin C. Harding 2024-07-17 06:06:06 +10:00
parent 86de586898
commit 98fe6179db
No known key found for this signature in database
GPG Key ID: 40BF9E4C269D6607
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hashes/src/sha256.rs
View File

@ -149,7 +149,7 @@ impl Hash {
pub const fn const_hash(bytes: &[u8]) -> Self { Hash(Midstate::const_hash(bytes, true).bytes) } pub const fn const_hash(bytes: &[u8]) -> Self { Hash(Midstate::const_hash(bytes, true).bytes) }
} }
/// Output of the SHA256 hash function. /// Unfinalized output of the SHA256 hash function.
/// ///
/// The `Midstate` type is obscure and specialized and should not be used unless you are sure of /// The `Midstate` type is obscure and specialized and should not be used unless you are sure of
/// what you are doing. /// what you are doing.