milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#3812: Remove unnecessary floating code comment 

2e482f0fdd Remove unnecessary floating code comment (Tobin C. Harding)

Pull request description:

  Code comments that comment and arbitrary block "section" of code are almost always pointless and almost always go stale over time.

  These particular code comments add almost no value.

  Remove code comments.

ACKs for top commit:
  jamillambert:
    ACK 2e482f0fdd
  apoelstra:
    ACK 2e482f0fddb55da897f0ba8ea4d3fa5bb0fba1b5; successfully ran local tests; yeah, in this case I agree

Tree-SHA512: 9cd5891e4d91af5206d99b5a2021bc82cc33e3c11d66364442a1a16866d2329ed3a005865cec1a76db80eb3191495a1710a683bc5a69284a29f164a1285b42ea
This commit is contained in:
merge-script 2024-12-29 18:22:40 +00:00
parent 779768eff9 2e482f0fdd
commit b2a2e8e708
No known key found for this signature in database
GPG Key ID: C588D63CE41B97C1
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
units/src/amount/signed.rs
View File

@ -297,8 +297,6 @@ impl SignedAmount {
self.display_in(denom).show_denomination().to_string() self.display_in(denom).show_denomination().to_string()
} }
// Some arithmetic that doesn't fit in [`core::ops`] traits.
/// Gets the absolute value of this [`SignedAmount`]. /// Gets the absolute value of this [`SignedAmount`].
#[must_use] #[must_use]
pub fn abs(self) -> SignedAmount { SignedAmount(self.0.abs()) } pub fn abs(self) -> SignedAmount { SignedAmount(self.0.abs()) }

2
units/src/amount/unsigned.rs
View File

@ -298,8 +298,6 @@ impl Amount {
self.display_in(denom).show_denomination().to_string() self.display_in(denom).show_denomination().to_string()
} }
// Some arithmetic that doesn't fit in [`core::ops`] traits.
/// Checked addition. /// Checked addition.
/// ///
/// Returns [`None`] if the sum is larger than [`Amount::MAX`]. /// Returns [`None`] if the sum is larger than [`Amount::MAX`].