milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#1063: Remove duplicate `must_use` 

bea5569cd3 Remove duplicate must_use (Tobin C. Harding)

Pull request description:

  Clippy emits:

   warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]`

  This is because the return type of the function `legacy_encode_signing_data_to` is `EncodeSigningDataResult` which is
  already marked as `must_use`. There is no need to have `must_use` on the function also.

  ##

  Hey apoelstra, this PR is needed before any other PR can get a green CI run. The PR that introduced this warning must have had a green CI run before the 'add clippy to CI' PR merged allowing it to merge without re-running CI.

ACKs for top commit:
  apoelstra:
    ACK bea5569cd3
  Kixunil:
    ACK bea5569cd3

Tree-SHA512: 27b606685bc2d5317a5e332431511af9b1017bf58462c283b322e5b6faf645fd8e006455af3d6888ab2c3c680b11e4b89f538f26440f4f1422e0daabc61825ac
This commit is contained in:
Andrew Poelstra 2022-06-24 16:31:37 +00:00
parent 99af5b9cfc bea5569cd3
commit b645b6b4b5
No known key found for this signature in database
GPG Key ID: C588D63CE41B97C1
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/util/sighash.rs
View File

@ -647,7 +647,6 @@ impl<R: Deref<Target = Transaction>> SighashCache<R> {
/// Encodes the legacy signing data for any flag type into a given object implementing a
/// [`std::io::Write`] trait. Internally calls [`Transaction::encode_signing_data_to`].
#[must_use]
pub fn legacy_encode_signing_data_to<Write: io::Write, U: Into<u32>>(
&self,
mut writer: Write,