milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#2046: Add one ACK carve-out 

4222e4d817 Add one-ack carve outside (Tobin C. Harding)

Pull request description:

  In an effort to reduce review burden add so strict rules defining 3 times where we think it is acceptable for code to be merged with a single ACK. Feels a bit like we only just added the refactor carve-out and now we are adding more carve-outs, so whats next? We should take these rules seriously, if we are to be taken seriously.

  ```
  We reserve the right to merge PRs with a single ACK [0], at any time, if they match
  any of the following conditions:

  1. PR only touches CI i.e, only changes any of the `test.sh` scripts and/or
     stuff in `.github/workflows`.
  2. Non-content changing documentation fixes i.e., grammar/typos, spelling, full
     stops, capital letters. Any change with more substance must still get two
     ACKs.
  3. Code moves that do not change the API i.e., moving error types to a submodule
     and re-exporting them from the original module.  Must not include any code
     changes except to import paths.

  [0] - Obviously author and ACK'er must not be the same person.
  ```

ACKs for top commit:
  apoelstra:
    ACK 4222e4d817
  sanket1729:
    ACK 4222e4d817
  RCasatta:
    ACK 4222e4d817

Tree-SHA512: b85645213a38e9d6dcb1a81ff2de3e24768716541ed34c250c66179ee7b19d426ec0bfc34386c7bb32cdc182de07146ac55a8c30c895e8b9febb498fbe1b3440
This commit is contained in:
Andrew Poelstra 2023-09-14 12:53:30 +00:00
parent 3dc75b5071 4222e4d817
commit bbe4800607
No known key found for this signature in database
GPG Key ID: C588D63CE41B97C1
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
CONTRIBUTING.md
View File

@ -174,6 +174,23 @@ created a carve out to the 2-ACK rule.
A PR may be considered for merge if it has a single ACK and has sat open for at A PR may be considered for merge if it has a single ACK and has sat open for at
least two weeks with no comments, questions, or NACKs. least two weeks with no comments, questions, or NACKs.
#### One ACK carve-out
We reserve the right to merge PRs with a single ACK [0], at any time, if they match
any of the following conditions:
1. PR only touches CI i.e, only changes any of the `test.sh` scripts and/or
stuff in `.github/workflows`.
2. Non-content changing documentation fixes i.e., grammar/typos, spelling, full
stops, capital letters. Any change with more substance must still get two
ACKs.
3. Code moves that do not change the API e.g., moving error types to a private
submodule and re-exporting them from the original module. Must not include
any code changes except to import paths. This rule is more restrictive than
the refactor carve-out. It requires absolutely no change to the public API.
[0] - Obviously author and ACK'er must not be the same person.
## Coding conventions ## Coding conventions
Library reflects Bitcoin Core approach whenever possible. Library reflects Bitcoin Core approach whenever possible.