Merge rust-bitcoin/rust-bitcoin#3258: Show output of failed semver checks

83831e6363 Show output of failed semver checks (Martin Habovstiak)

Pull request description:

  Debugging the API breaks without seeing what failed is pretty much impossible. This simply prints the output when a check fails.

ACKs for top commit:
  tcharding:
    ACK 83831e6363
  apoelstra:
    ACK 83831e6363 successfully ran local tests

Tree-SHA512: d3acd41ef745e8e19c0be8ca9c205f038a72d6d66c459564f6ea35cdef9402c07026e497e6ff6c8e1b80b4856fedfbf1d6f74adb40789b30bffd6e2a1ee76a2b

.github/workflows/semver-checks-pr-label.yml

@@ -73,7 +73,7 @@ jobs:
               owner: context.repo.owner,
               repo: context.repo.repo,
               issue_number: issue_number,
-              body: ':rotating_light: API BREAKING CHANGE DETECTED'
+              body: ':rotating_light: API BREAKING CHANGE DETECTED\n\nTo see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section.'
             });
 
             // add the label to the PR

contrib/check-semver-feature.sh

@@ -112,6 +112,7 @@ check_for_non_additive_cargo_features() {
         if grep -q "FAIL" "$file"; then
             echo "You have introduced non-additive cargo features"
             echo "FAIL found in $file"
+            cat "$file"
             # flag it as a breaking change
             # Handle the case where FAIL is found
             touch non-additive-cargo
@@ -133,4 +134,4 @@ err() {
 # Main script
 #
 main "$@"
-exit 0
+exit 0

contrib/check-semver-pr.sh

@@ -175,6 +175,7 @@ check_for_breaking_changes() {
         if grep -q "FAIL" "$file"; then
             echo "You have introduced changes to the public API"
             echo "FAIL found in $file"
+            cat "$file"
             # flag it as a breaking change
             # Handle the case where FAIL is found
             touch semver-break
@@ -189,4 +190,4 @@ check_for_breaking_changes() {
 # Main script
 #
 main "$@"
-exit 0
+exit 0