From 7f024c333e68a2bbb4e898424366bb9ae99da1cc Mon Sep 17 00:00:00 2001 From: Martin Habovstiak Date: Sun, 30 Jun 2024 09:40:37 +0200 Subject: [PATCH] Revert "bug fix" (actually a bug) from #2655 In a2b019f82 it was claimed that losing the input string without alloc is a bug. It is not, because allowing no-alloc is desired and there's no way to have the input string otherwise so we just accept it'll be missing and modify the messages accordingly. The commit that forced alloc was also horribly misleading since it kept the `alloc` feature but it makes this one easier. Note that input string is still present by default in all configurations except for no-alloc. --- units/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/units/Cargo.toml b/units/Cargo.toml index 6da54ff95..54143dcb3 100644 --- a/units/Cargo.toml +++ b/units/Cargo.toml @@ -18,7 +18,7 @@ std = ["alloc", "internals/std"] alloc = ["internals/alloc"] [dependencies] -internals = { package = "bitcoin-internals", version = "0.3.0", features = ["alloc"] } +internals = { package = "bitcoin-internals", version = "0.3.0" } serde = { version = "1.0.103", default-features = false, features = ["derive"], optional = true }