From ef116ffbedb65dbf4cdcfd79b45a93c6ffb84cc6 Mon Sep 17 00:00:00 2001
From: Andrew Poelstra <apoelstra@wpsoftware.net>
Date: Sat, 9 Jan 2021 16:43:18 +0000
Subject: [PATCH] Add byteorder pinning for 1.29.0 compatibility

They broke their MSRV in a minor release.

Co-authored-by: Sebastian Geisler <sebastian@blockstream.io>
---
 README.md       |  5 +++++
 contrib/test.sh | 14 ++++++++------
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index 56a12282..8b2aecad 100644
--- a/README.md
+++ b/README.md
@@ -66,6 +66,11 @@ cargo update --package "serde" --precise "1.0.98"
 cargo update --package "serde_derive" --precise "1.0.98"
 ```
 
+For the feature `base64` to work with 1.29.0 we also need to pin `byteorder`:
+```
+cargo update -p byteorder --precise "1.3.4"
+```
+
 ## Installing Rust
 Rust can be installed using your package manager of choice or
 [rustup.rs](https://rustup.rs). The former way is considered more secure since
diff --git a/contrib/test.sh b/contrib/test.sh
index b4bf59dd..55f43f6b 100755
--- a/contrib/test.sh
+++ b/contrib/test.sh
@@ -2,12 +2,17 @@
 
 FEATURES="base64 bitcoinconsensus use-serde rand"
 
-# Pin `cc` for Rust 1.29
-if [ -n "$PIN_VERSIONS" ]; then
+pin_common_verions() {
     cargo generate-lockfile --verbose
     cargo update -p cc --precise "1.0.41" --verbose
     cargo update -p serde --precise "1.0.98" --verbose
     cargo update -p serde_derive --precise "1.0.98" --verbose
+}
+
+# Pin `cc` for Rust 1.29
+if [ -n "$PIN_VERSIONS" ]; then
+    pin_common_verions
+    cargo update -p byteorder --precise "1.3.4"
 fi
 
 if [ "$DO_COV" = true ]
@@ -58,10 +63,7 @@ then
 
     # Pin `cc` for Rust 1.29
     if [ -n "$PIN_VERSIONS" ]; then
-        cargo generate-lockfile --verbose
-        cargo update -p cc --precise "1.0.41" --verbose
-        cargo update -p serde --precise "1.0.98" --verbose
-        cargo update -p serde_derive --precise "1.0.98" --verbose
+        pin_common_verions
     fi
 
     cargo test --verbose