From ff6b1d4f19d2c34c100ff2c291f5cbb49b4b6bd6 Mon Sep 17 00:00:00 2001 From: "Jamil Lambert, PhD" Date: Mon, 16 Sep 2024 17:11:04 +0100 Subject: [PATCH] Remove unused variables and methods from docs Examples in documentation are not linted in the same way as other code, but should still contain correctly written code. Throughout the bitcoin crate unused variables have either been prefixed with _ or an assert used. And unused methods have been used in the example code. --- bitcoin/src/address/mod.rs | 6 +++--- bitcoin/src/network/params.rs | 2 ++ bitcoin/src/psbt/map/input.rs | 8 ++++---- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/bitcoin/src/address/mod.rs b/bitcoin/src/address/mod.rs index 38c171b37..7aa72868e 100644 --- a/bitcoin/src/address/mod.rs +++ b/bitcoin/src/address/mod.rs @@ -288,14 +288,14 @@ pub enum AddressData { /// /// // variant 1 /// let address: Address = "32iVBEu4dxkUQk9dJbZUiBiQdmypcEyJRf".parse().unwrap(); -/// let address: Address = address.require_network(Network::Bitcoin).unwrap(); +/// let _address: Address = address.require_network(Network::Bitcoin).unwrap(); /// /// // variant 2 -/// let address: Address = Address::from_str("32iVBEu4dxkUQk9dJbZUiBiQdmypcEyJRf").unwrap() +/// let _address: Address = Address::from_str("32iVBEu4dxkUQk9dJbZUiBiQdmypcEyJRf").unwrap() /// .require_network(Network::Bitcoin).unwrap(); /// /// // variant 3 -/// let address: Address = "32iVBEu4dxkUQk9dJbZUiBiQdmypcEyJRf".parse::>() +/// let _address: Address = "32iVBEu4dxkUQk9dJbZUiBiQdmypcEyJRf".parse::>() /// .unwrap().require_network(Network::Bitcoin).unwrap(); /// ``` /// diff --git a/bitcoin/src/network/params.rs b/bitcoin/src/network/params.rs index 9d9cc5f56..ca93169c6 100644 --- a/bitcoin/src/network/params.rs +++ b/bitcoin/src/network/params.rs @@ -61,6 +61,8 @@ //! # let _ = target.difficulty(signet); //! # //! # let custom = CustomParams::new(); +//! # let _ = custom.magic(); +//! # let _ = custom.challenge_script(); //! # let _ = target.difficulty(custom); //! # } //! ``` diff --git a/bitcoin/src/psbt/map/input.rs b/bitcoin/src/psbt/map/input.rs index e9502daf1..803780d23 100644 --- a/bitcoin/src/psbt/map/input.rs +++ b/bitcoin/src/psbt/map/input.rs @@ -144,8 +144,8 @@ pub struct Input { /// use bitcoin::{EcdsaSighashType, TapSighashType}; /// use bitcoin::psbt::PsbtSighashType; /// -/// let ecdsa_sighash_all: PsbtSighashType = EcdsaSighashType::All.into(); -/// let tap_sighash_all: PsbtSighashType = TapSighashType::All.into(); +/// let _ecdsa_sighash_all: PsbtSighashType = EcdsaSighashType::All.into(); +/// let _tap_sighash_all: PsbtSighashType = TapSighashType::All.into(); /// ``` #[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)] #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] @@ -208,8 +208,8 @@ impl PsbtSighashType { /// ``` /// use bitcoin::{EcdsaSighashType, TapSighashType}; /// use bitcoin::psbt::PsbtSighashType; - /// let ecdsa_sighash_anyone_can_pay: PsbtSighashType = EcdsaSighashType::AllPlusAnyoneCanPay.into(); - /// let tap_sighash_anyone_can_pay: PsbtSighashType = TapSighashType::AllPlusAnyoneCanPay.into(); + /// let _ecdsa_sighash_anyone_can_pay: PsbtSighashType = EcdsaSighashType::AllPlusAnyoneCanPay.into(); + /// let _tap_sighash_anyone_can_pay: PsbtSighashType = TapSighashType::AllPlusAnyoneCanPay.into(); /// ``` pub const ALL: PsbtSighashType = PsbtSighashType { inner: 0x01 };