milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity

Merge rust-bitcoin/rust-bitcoin#690: BUG: Does not work with `no_std` under 1.29 (MSRV) 

7854bd7918 Fix `no_std` MSRV Fixes #690, #947 (mcroad)

Pull request description:

  `rust-bitcoin` does not work with rust 1.29 under a `no_std` environment. This could be considered a bug. However, `no_std` support is a recent addition and this is likely not breaking anyone's builds.

  A decision needs to be made, either `no_std` MSRV is the current stable version while keeping the `std` MSRV as 1.29, or it needs to be fixed.

  This pr adds `no_std` to the 1.29 test suite.

  This came as I try to get rust-bitcoin/rust-miniscript#277 working and got stuck on the issue of testing `no_std` under 1.29.

ACKs for top commit:
  Kixunil:
    ACK 7854bd7918
  tcharding:
    ACK 7854bd7918
  sanket1729:
    ACK 7854bd7918
  apoelstra:
    ACK 7854bd7918

Tree-SHA512: 1614fb2193f760ed340592bdb94d076066f6f783bc1dc2b145d97f7151a28316e56b1975f1ad948460eb26db04e7e9382e60076686a681e46dcf33521fda5fca
This commit is contained in:
Andrew Poelstra 2022-04-30 15:50:36 +00:00
parent 0dd2b433a0 7854bd7918
commit ff6dc61967
No known key found for this signature in database
GPG Key ID: C588D63CE41B97C1
4 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/rust.yml vendored
View File

@ -28,6 +28,10 @@ jobs:
- rust: 1.41.1 - rust: 1.41.1
env: env:
AS_DEPENDENCY: true AS_DEPENDENCY: true
- rust: 1.47
env:
AS_DEPENDENCY: true
DO_NO_STD: true
steps: steps:
- name: Checkout Crate - name: Checkout Crate
uses: actions/checkout@v2 uses: actions/checkout@v2

1
.gitignore vendored
View File

@ -1,5 +1,6 @@
target target
Cargo.lock Cargo.lock
dep_test
#fuzz #fuzz
fuzz/hfuzz_target fuzz/hfuzz_target

3
README.md
View File

@ -77,7 +77,8 @@ please join us in
## Minimum Supported Rust Version (MSRV) ## Minimum Supported Rust Version (MSRV)
This library should always compile with any combination of features on **Rust 1.29**. This library should always compile with any combination of features (minus
`no-std`) on **Rust 1.41.1** or **Rust 1.47** with `no-std`.
Because some dependencies have broken the build in minor/patch releases, to Because some dependencies have broken the build in minor/patch releases, to
compile with 1.29.0 you will need to run the following version-pinning command: compile with 1.29.0 you will need to run the following version-pinning command:

3
src/util/bip32.rs
View File

@ -74,7 +74,8 @@ impl fmt::Debug for ExtendedPrivKey {
.field("parent_fingerprint", &self.parent_fingerprint) .field("parent_fingerprint", &self.parent_fingerprint)
.field("child_number", &self.child_number) .field("child_number", &self.child_number)
.field("chain_code", &self.chain_code) .field("chain_code", &self.chain_code)
.finish_non_exhaustive() .field("private_key", &"[SecretKey]")
.finish()
} }
} }