fdbccf055d
Remove variable shadowing in listener.rs
2018-08-15 09:43:35 +03:00
14f5db070a
Merge pull request #132 from dongcarl/deserialize-fix
...
Ready for Review: Make deserialize error if input bytes not consumed
2018-08-15 01:35:21 +00:00
70203831d6
Make deserialize error if input bytes not consumed
...
- Adjust tests in encodable.rs to account for this change
2018-08-14 16:50:33 -07:00
bf9c749b0c
Merge pull request #129 from dongcarl/bip32-derive-test
...
Ready for Review: Add derive_* methods to Extended*Key
2018-08-13 20:52:07 +00:00
60577f286d
Add derive_* methods to Extended*Key
...
- Add derive_pub to ExtendedPubKey
- Add derive_priv to ExtendedPrivKey
- Removed from_path from ExtendedPrivKey as it is superseded by
derive_priv
- Add checking of derive_pub and derive_priv to test_path
- Add checking of correct error when invoking ckd_pub on a hardened
ChildNumber
- Add test vector 3 from BIP32 specification
2018-08-12 17:16:33 -07:00
bc7125e955
Merge pull request #119 from jeandudey/2018-08-08-try-op
...
Remove `try!` macro usage and use the `?` operator instead.
2018-08-12 23:44:43 +00:00
c16ae47871
Merge pull request #127 from jeandudey/2018-08-12-c-hidden
...
Hidde `From<T>` implementations for error types in Rustdoc.
2018-08-12 23:43:01 +00:00
f918311b8a
Remove unused "bitcoinconsenus" feature.
...
Also I've updated the feature name on the README.md, and fixed a typo in
src/blockdata/script.rs
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
2018-08-12 16:06:06 -04:00
6e99d2d33c
Hidde `From<T>` implementations for error types in Rustdoc.
...
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
2018-08-12 12:57:59 -04:00
b2594087db
Use the `?` (try) instead of the `try!` macro.
...
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
2018-08-12 12:47:31 -04:00
24c0f1a3fc
Merge pull request #118 from jeandudey/2018-08-08-bip32-tostring
...
Implement `Display` trait instead of implementing `ToString` directly.
2018-08-12 13:48:39 +00:00
147259d957
Merge pull request #126 from dongcarl/bip32-consistency
...
Ready for Review: Improve consistency for bip32::ChildNumber
2018-08-11 23:38:41 +00:00
c485a74c09
Add helper methods is_normal, is_hardened
...
- Fix documentation links
2018-08-11 13:29:10 -07:00
4a5bf52ed9
Improve consistency for bip32::ChildNumber
...
There seemed to be some confusion as to whether the internal
represenation of a ChildNumber is supposed to be the index (0..2^31-1
for _both_ Normal and Hardened) or the actual number (0..2^31-1 for
Normal and 2^31..2^32-1 for Hardened). This commits fixes this
confusion.
- Make clear that the internal representation is the index rather
than the actual number
- Make the internal representation non-public
- Provide methods for creating valid ChildNumbers
- Change relevant callers and tests to conform to this new ChildNumber
My rationale for using index rather than the actual number as internal
representation is that the difference between the two enum variants
already encode wether a ChildNumber is a normal one or a hardened one,
so the only bit of extra information left to be encoded is its index.
2018-08-11 12:46:46 -07:00
ebe5133d1a
Merge pull request #110 from D4nte/regtest
...
Regtest bech32 address support
2018-08-11 17:21:12 +00:00
259c5902f1
Merge pull request #116 from jeandudey/2018-08-08-module-docs
...
Fix modules documentation title.
2018-08-11 17:12:50 +00:00
ee9802d813
Merge pull request #120 from dpc/from_secret_key-doc-fix
...
Simple doc fix for `from_secret_key`
2018-08-11 17:05:29 +00:00
e17c280e4f
Merge pull request #121 from jeandudey/2018-08-10-network
...
Refactor and add more documentation for the `Network` type.
2018-08-11 16:52:52 +00:00
6c53593d5f
Merge pull request #122 from dongcarl/childnumber-fixes
...
Add conversion between u32 and ChildNumber, fix docs
2018-08-10 22:46:22 +00:00
d4f28b6785
Add conversion between u32 and ChildNumber, fix docs
2018-08-10 13:49:45 -07:00
7ecb6b9dea
Refactor and add more documentation for the `Network` type.
...
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
2018-08-10 14:56:19 -04:00
1646a80f77
Simple doc fix for `from_secret_key`
2018-08-09 15:41:48 -07:00
0225b530cc
Implement `Display` trait instead of implementing `ToString` directly.
...
ExtendedPubKey and ExtendedPrivKey implemented `ToString` directly but
Rust documentation says to implement `Display` and get the `ToString`
implementation for free.
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
2018-08-08 19:11:16 -04:00
77c185d9ec
Fix modules documentation title.
...
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
2018-08-08 17:38:50 -04:00
45c699f005
Merge pull request #112 from TheBlueMatt/2018-07-p2wsh-name
...
Clarify to_v0_p2wsh docs a bit further
2018-07-28 18:28:00 +00:00
cdb7ca83c9
Merge pull request #107 from savil/remove-rustc-serialize
...
[code hygiene] remove deprecated rustc-serialize
2018-07-28 18:24:50 +00:00
3686cd7201
Clarify to_v0_p2wsh docs a bit further
2018-07-26 15:13:44 -04:00
933dcaeb82
[code hygiene] remove deprecated rustc-serialize
...
Addresses #96 .
Turns out it was being used for hex encoding/decoding, so replaced that with the `hex` crate.
i chose to import the `decode` method as:
```
use hex::decode as hex_decode
```
so that it is clear to the reader what is being decoded when it is called. "decode" is such a generic sounding function name that it would get confusing otherwise.
2018-07-26 09:49:15 -07:00
f05f831569
Regtest has a longer hrp, need to adjust length safety check
2018-07-26 17:06:35 +10:00
0f31608796
Add support for bech32 regtest address format
2018-07-26 10:51:37 +10:00
ba2879cfac
Add test for regtest network
2018-07-26 10:51:15 +10:00
f7ab3241a7
Merge pull request #109 from dongcarl/patch-1
...
Fix to_v0_p2wsh docs
2018-07-26 00:42:24 +00:00
db76a63669
Fix to_v0_p2wsh docs
2018-07-25 17:11:27 -07:00
a7aff1372e
Merge pull request #100 from sgeisler/bech32-v0.6.1
...
Use bech32 v0.8.0
2018-07-25 21:24:26 +00:00
00cca03edd
use bitcoin-bech32 v0.8.0 and adapt internal API usage
2018-07-25 21:09:46 +02:00
9ab2aa52fd
Merge pull request #101 from tamasblummer/is_op_return
...
check if output is OP_RETURN
2018-06-23 15:19:18 +00:00
caeadb42be
check if output is OP_RETURN
2018-06-23 14:49:55 +02:00
2ff5f8e51e
Added module with consensus parameters ( #93 )
2018-06-23 10:23:34 +02:00
93d426db2e
Merge pull request #99 from rust-bitcoin/2018-06-revert-pr-84
...
Reverts #84 , bumps Cargo minor version number, and re-adds #84
2018-06-22 16:12:53 +00:00
7988b78c1f
Added regtest
...
Completed regtest integration to the code
Added tests for regtest
Get rid of panics
2018-06-16 22:56:32 +00:00
5c753fb517
Bump version to 0.13.2
2018-06-16 22:55:27 +00:00
bc5cb3bc31
Revert "Added regtest"
...
This reverts commit 34e228c699
2018-06-16 22:55:12 +00:00
14a920ab7d
Added method to convert target from Uint256 to compact form ( #86 )
...
Renamed method for getting compact from u256
Removed unnecessary asserts from convert function
2018-06-12 20:58:25 +02:00
18460e347e
Merge pull request #97 from romanz/master
...
Fix 2 small typos in comments
2018-06-10 21:09:15 +00:00
69ea2a760b
Fix 2 small typos in comments
2018-06-09 22:27:40 +03:00
6dc2ad86f0
Merge pull request #92 from rust-bitcoin/version-0.13.1
...
bump version to 0.13.1
2018-06-04 21:02:20 +00:00
2db9aeab2d
bump version to 0.13.1
2018-06-04 19:29:59 +00:00
62d080afc7
Merge pull request #83 from tamasblummer/is_coinbase
...
add is_coin_base
2018-06-04 18:46:03 +00:00
dd176b4177
Merge pull request #84 from popzxc/add-regtest
...
Added regtest network
2018-06-04 18:42:05 +00:00
fb0c782df6
Merge pull request #89 from tamasblummer/wittness_block
...
add witness inv types
2018-06-04 18:34:28 +00:00
Roman Zeyde
Andrew Poelstra
Carl Dong
Jean Pierre Dudey
Dawid Ciężarkiewicz
Matt Corallo
Savil Srivastava
Franck Royer
Sebastian Geisler
Tamas Blummer
Igor Aleksanov
Igor Aleksanov