milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity
rust-bitcoin-unsafe-fast/api
History
Andrew Poelstra 4fde89f77c
Merge rust-bitcoin/rust-bitcoin#2795: Make `Address:p2sh_from_hash` public 
3615410d21 api: Run just check-api (Tobin C. Harding)
a3d2d1a184 Make Address:p2sh_from_hash public (Tobin C. Harding)

Pull request description:

  We previously made this function Private and added a comment that doing so was somehow better to remove the footgun of hashing the wrong length script. However in hindsight this was a bad idea and users want the functionality.

  Make the `Address:p2sh_from_hash` public and document it as we do for `Address::p2sh`.

  This is an additive change and is expected to be backported to `v0.32`, as part of the fix to #2784. Please note it introduces the footgun that is described in the function rustdoc. This will be improved as a separate patch and added to the current release.

ACKs for top commit:
  apoelstra:
    ACK 3615410d21

Tree-SHA512: 535bb7894eeef8ecb5afb7bf6e5c483cd42c6a4282d1c116e5bf86cd1364a8327bbec1efb8634a578f07ad2832c1e5daf7fe7e844574b88b1ad355a443627bef
 		2024-05-25 21:12:12 +00:00
..
base58 Add a script to check the public API 2024-05-18 09:54:52 +10:00
bitcoin Merge rust-bitcoin/rust-bitcoin#2795: Make `Address:p2sh_from_hash` public 2024-05-25 21:12:12 +00:00
hashes Add a script to check the public API 2024-05-18 09:54:52 +10:00
io Add a script to check the public API 2024-05-18 09:54:52 +10:00
units api: Run just check-api 2024-05-24 14:48:48 +10:00
README.md Add a script to check the public API 2024-05-18 09:54:52 +10:00

README.md

API text files

Each file here lists the public API when built with some set of features enabled. To create these files run ../contrib/check-for-api-changes.sh:

Requires cargo-public-api, install with:

cargo +stable install cargo-public-api --locked

ref: https://github.com/enselic/cargo-public-api