rust-bitcoin-unsafe-fast/bitcoin
Andrew Poelstra 205544b6aa
Merge rust-bitcoin/rust-bitcoin#1862: crypto: Overhaul the errors
3c0bb63423 Do trivial rustdoc improvements (Tobin C. Harding)
3225aa9556 Use defensive documentation (Tobin C. Harding)
80d5d6665a crypto: key: Move error code to the bottom of the file (Tobin C. Harding)
fe3b1e1140 Move From for Error impl (Tobin C. Harding)
5f8e0ad67e Fix docs on error type (Tobin C. Harding)
f23155aa16 Do not capitalize error messages (Tobin C. Harding)
ae07786c27 Add InvalidSighashTypeError (Tobin C. Harding)
baba0fde57 Put NonStandardSighashTypeError inside ecdsa::Error variant (Tobin C. Harding)
6c9d9d9c36 Improve error display imlps (Tobin C. Harding)
22c7aa8808 Rename non standard sighash error type (Tobin C. Harding)

Pull request description:

  EDIT: The commit hashes below are stale but the text is valid still.

  In an effort to "perfect" our error handling, overhaul the error handling in the `crypto` module.

  The aim is to do a small chunk so we can bikeshed on it then I can apply the learnings to the rest of the codebase.

  Its all pretty trivial except:

  - commit `4c180277 Put NonStandardSighashTypeError inside ecdsa::Error variant`
  - comimt `5a196535 Add InvalidSighashTypeError`
  - commit `05772ade Use defensive documentation`

  Particularly the last one might be incorrect/controversial.

  Also, please take the time to check the overall state of error code in the `crypto` module on this branch in case there is anything else we want to do.

  Thanks

ACKs for top commit:
  apoelstra:
    ACK 3c0bb63423

Tree-SHA512: 7e5f8590aec5826098d4d8d33351a41b10c42b6379ff86e5b889e73271b71921fc3ca9525baa5da53e07fa2e961e710393694e04658a8243799950b4604caf43
2023-08-02 13:18:19 +00:00
..
contrib CI: Pin serde_json for MSRV build 2023-07-12 15:50:18 +10:00
embedded Add patch section to test crates 2023-07-18 10:27:48 +10:00
examples Move p2p::constants::Network to crate root 2023-08-01 16:46:59 +10:00
src Merge rust-bitcoin/rust-bitcoin#1862: crypto: Overhaul the errors 2023-08-02 13:18:19 +00:00
tests Depend on hex-conservative 2023-07-21 10:59:46 +10:00
CHANGELOG.md Add changelo entry for removal of FromHex 2023-05-18 14:18:42 +10:00
Cargo.toml Merge rust-bitcoin/rust-bitcoin#1833: Use new `hex-conservative` crate 2023-07-27 16:27:01 +00:00
build.rs Remove rust_v_1_46 2023-03-23 08:27:10 +11:00