merge-script e45bc0056c Merge rust-bitcoin/rust-bitcoin#3981: Do not implement `Default` for `HmacEngine` ... 18619a6d0b api: Run just check-api (Tobin C. Harding) 1eb8f1f9e0 Add a Hmac::engine function (Tobin C. Harding) c352d376ed Do not implement Default for HmacEngine (Tobin C. Harding) Pull request description: The `HmacEngine` should be created using a key. Currently we are providing a `Default` impl that uses `&[]` as the key. This is, I believe, a hangover from when we had a `Default` trait bound somewhere else. It is incorrect and an API footgun - remove it. Note this PR includes changes to the bench code in `hmac` that highlights the footgun - pity the poor user we even shot ourselves. Patch 2 adds a constructor `Hmac::engine` and uses it in the bench code. ACKs for top commit: Kixunil: ACK 18619a6d0b apoelstra: ACK 18619a6d0b0bca7b7e3603e260b254b4aae6cebf; successfully ran local tests Tree-SHA512: c96640e7ffba52d5b13b76a6dd9e1381788efcf56ee76300c5111541466bab8018d2546bcecf237c42dbd82e9372a0e43e1ecec37147508e879365d92a4c1451		2025-01-31 20:29:55 +00:00
..
all-features.txt	Merge rust-bitcoin/rust-bitcoin#3981: Do not implement `Default` for `HmacEngine`	2025-01-31 20:29:55 +00:00
alloc-only.txt	Merge rust-bitcoin/rust-bitcoin#3981: Do not implement `Default` for `HmacEngine`	2025-01-31 20:29:55 +00:00
no-features.txt	Merge rust-bitcoin/rust-bitcoin#3981: Do not implement `Default` for `HmacEngine`	2025-01-31 20:29:55 +00:00