Andrew Poelstra 4b02d90ce4 Merge rust-bitcoin/rust-bitcoin#1578: Implement `Debug` for generic `Address<V: NetworkValidation>` ... ebfbe74243 Implement `Debug` for generic `Address<V: NetworkValidation>` (Jiri Jakes) Pull request description: Previously `Debug` was implemented for both `Address<NetworkChecked>` and `Address<NetworkUnchecked>`, but not for cases when the `NetworkValidation` parameter was generic. This change adds this ability. Based on Kixunil's tip. With previous implementation, the `test_address_debug()` resulted in error:  The added `Debug` on `NetworkChecked` and `NetworkUnchecked` are required by compiler. --- While dealing with derives and impls, I also attempted to turn all the derives on `Address` into manual impls (see Kixunil's suggestion in https://github.com/rust-bitcoin/rust-bitcoin/pull/1489#discussion_r1052448057). The motivation behind this was the possibility to remove derives on `NetworkChecked` and `NetworkUnchecked`, too. However, even with manual impls, all the traits on `NetworkChecked` and `NetworkUnchecked` were still required by compiler in this sort of situations (see also the rest of the same discussion linked above). I do not fully understand why, perhaps limitation of this way of sealing traits? It can be demonstrated by removing `Debug` derivation on `NetworkUnchecked` and `NetworkChecked` in this PR and running `test_address_debug()`. Therefore, if we want to allow users of the library to define types generic in `NetworkValidation` and at the same time derive impls, it seems to me that `NetworkChecked` and `NetworkUnchecked` will have to have the same set of impls as `Address` itself. ACKs for top commit: Kixunil: ACK ebfbe74243 tcharding: ACK ebfbe74243 apoelstra: ACK ebfbe74243 Tree-SHA512: 87f3fa4539602f31bf4513a29543b04e943c3899d8ece36d0d905c3b5a2d76e29eb86242694b5c494faa5e54bb8f69f5048849916c6438ddd35030368f710353		2023-01-23 14:49:22 +00:00
..
contrib	Remove rand-std dev-dependency from secp256k1	2022-12-23 08:33:21 +11:00
embedded	Patch hashes and update the code	2022-12-18 14:33:55 +01:00
examples	Use marker type to enforce validation of `Address`'s network	2023-01-11 19:27:10 +08:00
fuzz	Use marker type to enforce validation of `Address`'s network	2023-01-11 19:27:10 +08:00
src	Merge rust-bitcoin/rust-bitcoin#1578: Implement `Debug` for generic `Address<V: NetworkValidation>`	2023-01-23 14:49:22 +00:00
tests	Use as_ref() instead of costly clone()	2023-01-09 23:17:04 -05:00
CHANGELOG.md	add some documentation clarifying the locktime ordering shenanigans in #1330	2022-12-15 23:12:03 +00:00
Cargo.toml	bip158: Replace usage of HashSet with BTreeSet	2023-01-23 08:38:08 +11:00
build.rs	Implement consensus encoding adapter for serde	2022-12-02 10:48:05 +01:00