The `units::locktime` types are used for two things: - They are the inner types of `primitives` `LockTime`s - They are used ephemerally for checking satisfaction Neither of these use cases requires `serde` impls for the `units` types. Since we are trying to release 1.0 with minimal amounts of code we should remove them. For `LockTime`s that need to be stored on disk or go over the wire we can manually implement the `serde` traits. For `absolute::LockTime` this is done already and there is no reason the `relative::LockTime` impl cannot be the same [0]. This differs from the current `serde` trait impls but we have already decided that in 0.33 we are going to accept breakage and direct users to use 0.32 to handle it. - Remove `serde` stuff from `units::locktime` - Manually implement `serde` traits on `relative::LockTime` - Fix the regression test to use the new format While we are at it use a uniform terse call in `serialize`. [0] This is because there is an unambiguous encoding for the whole set of locktimes - consensus encoding. |
||
---|---|---|
.. | ||
serde | ||
README.md | ||
bip341_tests.json | ||
block_13b8a.hex | ||
blockfilters.json | ||
combine_psbt_hex | ||
create_psbt_hex | ||
extract_tx_hex | ||
finalize_psbt_hex | ||
huge_witness.hex | ||
legacy_sighash.json | ||
lex_combine_psbt_hex | ||
lex_psbt_1_hex | ||
lex_psbt_2_hex | ||
mainnet_block_000000000000000000000c835b2adcaedc20fdf6ee440009c249452c726dafae.raw | ||
merkle_block.hex | ||
previous_tx_0_hex | ||
previous_tx_1_hex | ||
psbt1.hex | ||
psbt2.hex | ||
psbt_combined.hex | ||
psbt_fuzz1.hex | ||
psbt_fuzz2.hex | ||
sign_1_psbt_hex | ||
sign_2_psbt_hex | ||
testnet_block_000000000000045e0b1660b6445b5e5c5ab63c9a4f956be7e1e69be04fa4497b.raw | ||
update_1_psbt_hex | ||
update_2_psbt_hex |
README.md
Test vector data
This file contains data (hex strings) taken from BIP test vectors.