rust-bitcoin-unsafe-fast/bitcoin
Andrew Poelstra a0540bdb21
Merge rust-bitcoin/rust-bitcoin#2064: Feature: Psbt fee checks
dac627cc09 Feature: Psbt fee checks (junderw)

Pull request description:

  Closes #2061

  These new methods on Psbt will add checks for high fees by default. The threshold for "high fees" is currently set to 25000 sat/vbyte, which is about 20x higher than the highest next block fees seen on the "Mempool" website.

  The primary goal of this change is to prevent users of the library from accidentally sending absurd amounts of fees.

  (ie. Recently in September 2023 there was a transaction that sent an absurd amount of fees and made news in the Bitcoin world. Luckily the mining pool gave it back, but some might not be so lucky.)

  There are variants of the method that allow for users to set their own "absurd" threshold using a `FeeRate` value. And there is a method that performs no checks, and the method name is alarming enough to draw attention in a review, so at least developers will be aware of the concept.

ACKs for top commit:
  apoelstra:
    ACK dac627cc09
  tcharding:
    ACK dac627cc09

Tree-SHA512: ae0beafdb50339ba3efc44a48ba19c0aeeb0a2671eb43867c1e02b807677ce99fb6b4c47b74a9ed2999f827b3edc00a8871fa4730dd12a4cb265be99437c13db
2023-09-29 17:13:30 +00:00
..
contrib hashes: Bump version to 0.13.0 2023-08-24 12:25:42 +10:00
embedded Add patch section to test crates 2023-07-18 10:27:48 +10:00
examples Feature: Psbt fee checks 2023-09-28 00:11:33 -07:00
src Merge rust-bitcoin/rust-bitcoin#2064: Feature: Psbt fee checks 2023-09-29 17:13:30 +00:00
tests Feature: Psbt fee checks 2023-09-28 00:11:33 -07:00
CHANGELOG.md Add changelog entries 2023-09-25 07:44:26 +10:00
Cargo.toml Use the new bech32 iterator API 2023-09-21 15:10:57 +10:00
build.rs Remove rust_v_1_46 2023-03-23 08:27:10 +11:00