milksad
/
rust-bitcoin-unsafe-fast
14
0
Fork 0
Code Issues Pull Requests Activity
rust-bitcoin-unsafe-fast/api
History
merge-script e45bc0056c
Merge rust-bitcoin/rust-bitcoin#3981: Do not implement `Default` for `HmacEngine` 
18619a6d0b api: Run just check-api (Tobin C. Harding)
1eb8f1f9e0 Add a Hmac::engine function (Tobin C. Harding)
c352d376ed Do not implement Default for HmacEngine (Tobin C. Harding)

Pull request description:

  The `HmacEngine` should be created using a key. Currently we are providing a `Default` impl that uses `&[]` as the key. This is, I believe, a hangover from when we had a `Default` trait bound somewhere else. It is incorrect and an API footgun - remove it.

  Note this PR includes changes to the bench code in `hmac` that highlights the footgun - pity the poor user we even shot ourselves.

  Patch 2 adds a constructor `Hmac::engine` and uses it in the bench code.

ACKs for top commit:
  Kixunil:
    ACK 18619a6d0b
  apoelstra:
    ACK 18619a6d0b0bca7b7e3603e260b254b4aae6cebf; successfully ran local tests

Tree-SHA512: c96640e7ffba52d5b13b76a6dd9e1381788efcf56ee76300c5111541466bab8018d2546bcecf237c42dbd82e9372a0e43e1ecec37147508e879365d92a4c1451
 		2025-01-31 20:29:55 +00:00
..
hashes Merge rust-bitcoin/rust-bitcoin#3981: Do not implement `Default` for `HmacEngine` 2025-01-31 20:29:55 +00:00
io Run just check-api 2025-01-22 10:18:11 +00:00
primitives api: Run just check-api 2025-01-30 08:17:15 +01:00
units Merge rust-bitcoin/rust-bitcoin#3937: Manual update to rustc (to nightly-2025-01-16) 2025-01-23 02:56:29 +00:00
README.md api: document the need of cargo nightly 2024-12-15 11:42:52 -03:00

README.md

API text files

Each file here lists the public API when built with some set of features enabled. To create these files run ../contrib/check-for-api-changes.sh:

Requires cargo-public-api, install with:

cargo +nightly install cargo-public-api --locked

ref: https://github.com/enselic/cargo-public-api