rust-bitcoin-unsafe-fast/bitcoin
Andrew Poelstra ea606d93a0
Merge rust-bitcoin/rust-bitcoin#1682: Include address in Error::NetworkValidation
73e876ffd4 Include address in Error::NetworkValidation (Subhradeep Chakraborty)

Pull request description:

  Fixes: #1677

  ## Change
  In `bitcoin/src/address.rs`, a new field `address` is added to the enum variant `Error::NetworkValidation`. Also, the implementation of `Display` trait for `Error` is updated to print the `address` field.

  However, to print the `address` through `Display`, either the reference is needed or `Address` and `Payload` both need to derive the `Copy` trait. Since I am little new to both the rust-bitcoin codebase and rust itself, I am confused about choosing between the two and have moved with the first one. Would appreciate any feedback on this.

ACKs for top commit:
  Kixunil:
    ACK 73e876ffd4
  tcharding:
    ACK 73e876ffd4
  apoelstra:
    ACK 73e876ffd4

Tree-SHA512: dd53b8648bccc8372c829e56817402fb02a9d51d1dffc854f24e68814bbefe7ea777f67aefb0d170762dbf6cdd50bd3ec55af325a1ffc21b1241d1df5531cd24
2023-03-03 16:09:21 +00:00
..
contrib Pin syn dependency for MSRV toolchain 2023-02-24 08:41:40 +11:00
embedded Instruct devs to use nightly for embedded 2023-02-03 08:44:47 +11:00
examples Improve the public API 2023-03-01 09:28:42 +11:00
fuzz Add a newtype for script-pushable slice 2023-02-18 16:35:25 +01:00
src Merge rust-bitcoin/rust-bitcoin#1682: Include address in Error::NetworkValidation 2023-03-03 16:09:21 +00:00
tests Improve the public API 2023-03-01 09:28:42 +11:00
CHANGELOG.md add some documentation clarifying the locktime ordering shenanigans in #1330 2022-12-15 23:12:03 +00:00
Cargo.toml Re-name hash inner/byte methods 2023-02-27 14:23:58 +11:00
build.rs Set rustv_1_53 in build script 2023-02-02 10:12:16 +11:00