merge-script ee037042ae Merge rust-bitcoin/rust-bitcoin#4387: bip32: overhaul error types and add a "maximum depth exceeded" error ... b9a12043b0 bip32: return error when trying to derive a path too deep (Andrew Poelstra) 73781e047b bip32: rename Error to ParseError (Andrew Poelstra) a66ad97fb6 bip32: split InvalidChildNumber and InvalidChildNumberFormat out of error (Andrew Poelstra) a891fb9b74 bip32: remove unused error variants (Andrew Poelstra) f0a237c001 bip32: split out DerivationError from the main error enum (Andrew Poelstra) 32d96f6c33 bip32: make Xpriv::new_master be infallible (Andrew Poelstra) 0e5e021b69 bip32: change several cryptographically unreachable paths to expects (Andrew Poelstra) Pull request description: This PR makes a first pass at splitting the `bip32::Error` type into multiple distinct types -- one for derivation (which can fail if you try to derive a hardened child of an xpub, or if you try to derive too many layers), one for parsing child numbers or derivation paths, and one for parsing xkeys. Along the way it cleans up a ton of weird things and typos, e.g. the psbt `GetKeyError` having an unused `Bip32` variant whose display text references "bip 23". Because all the error types get renamed, every part of this PR is an API break, but only the last commit is a "real" API break which uses the new `DerivationError::MaximumDepthExceeded` error variant to return an error when trying to derive a path of length 256 or longer. This means that `Xpriv::derive_xpriv` again returns an error result. I will make a simpler version of this last commit suitable for backporting to 0.32.x. (In 0.32.x `Xpriv::derive_priv` returns an error, so we can change it to error out on max-depth-exceeded without breaking the API. Sadly most users are likely to be unwrapping the error because in 0.32.x currently the error path is cryptographically unreachable...but at least this way the panic will be in their control rather than ours.) Fixes https://github.com/rust-bitcoin/rust-bitcoin/issues/4308 ACKs for top commit: tcharding: ACK b9a12043b0 Tree-SHA512: 688826126ff24066c6de9de3caa73db68c516ba8893d64d9226a498774a2fb9db7d7fd797375c6b3f820588c178632e1e6e8561022dfa7042a560582bf1509b4		2025-04-30 13:12:01 +00:00
..
contrib	Remove rust-ordered dependency	2025-02-18 13:36:07 +11:00
embedded	chore: remove unused cortex-m dependency from embedded Cargo.toml files in bitcoin and hashes modules.	2025-04-05 18:25:41 +08:00
examples	Merge rust-bitcoin/rust-bitcoin#4387: bip32: overhaul error types and add a "maximum depth exceeded" error	2025-04-30 13:12:01 +00:00
src	Merge rust-bitcoin/rust-bitcoin#4387: bip32: overhaul error types and add a "maximum depth exceeded" error	2025-04-30 13:12:01 +00:00
tests	Merge rust-bitcoin/rust-bitcoin#4387: bip32: overhaul error types and add a "maximum depth exceeded" error	2025-04-30 13:12:01 +00:00
CHANGELOG.md	docs: correction CHANGELOG.md	2025-04-27 09:12:50 +02:00
Cargo.toml	bitcoin: Add a script encoding example	2025-04-28 13:38:12 +10:00