From c612130864ef8043ea952cf5879d256511cfbf27 Mon Sep 17 00:00:00 2001
From: Tobin Harding <me@tobin.cc>
Date: Thu, 24 Mar 2022 13:23:12 +1100
Subject: [PATCH] Borrow secret key

`SecretKey` implements `Copy` and it is fine to take owneship of it; we
have multiple methods called `from_secret_key` and they all borrow the
secret key parameter. Favour consistency over perfection.

Borrow secret key parameter as is done in other `from_secret_key`
methods.
---
 src/key.rs    | 6 +++---
 src/secret.rs | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/key.rs b/src/key.rs
index 82ffef9..9b1a84b 100644
--- a/src/key.rs
+++ b/src/key.rs
@@ -674,7 +674,7 @@ impl Ord for PublicKey {
 ///
 /// let secp = Secp256k1::new();
 /// let (secret_key, public_key) = secp.generate_keypair(&mut rand::thread_rng());
-/// let key_pair = KeyPair::from_secret_key(&secp, secret_key);
+/// let key_pair = KeyPair::from_secret_key(&secp, &secret_key);
 /// # }
 /// ```
 /// [`Deserialize`]: serde::Deserialize
@@ -706,7 +706,7 @@ impl KeyPair {
     #[inline]
     pub fn from_secret_key<C: Signing>(
         secp: &Secp256k1<C>,
-        sk: SecretKey,
+        sk: &SecretKey,
     ) -> KeyPair {
         unsafe {
             let mut kp = ffi::KeyPair::new();
@@ -1426,7 +1426,7 @@ pub mod serde_keypair {
 
         Ok(KeyPair::from_secret_key(
             &::SECP256K1,
-            secret_key,
+            &secret_key,
         ))
     }
 }
diff --git a/src/secret.rs b/src/secret.rs
index 493070f..7ee08ac 100644
--- a/src/secret.rs
+++ b/src/secret.rs
@@ -160,7 +160,7 @@ impl KeyPair {
     ///
     /// let secp = Secp256k1::new();
     /// let key = ONE_KEY;
-    /// let key = KeyPair::from_secret_key(&secp, key);
+    /// let key = KeyPair::from_secret_key(&secp, &key);
     /// // Here we explicitly display the secret value:
     /// assert_eq!(
     ///     "0000000000000000000000000000000000000000000000000000000000000001",